Merge pull request #64 from yosemiteyss/feat/merge-dev-to-main

merge dev to main

Author: yosemiteyss

.github/workflows/publish.yml

@@ -0,0 +1,47 @@
+name: Publish package
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  publish:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Dart SDK
+        uses: dart-lang/setup-dart@v1
+
+      - name: Install dependencies
+        run: dart pub get
+
+      - name: Run tests
+        run: dart test
+
+      - name: Setup pub.dev credentials
+        run: |
+          mkdir -p ${{ runner.workspace }}/.config/dart
+          echo "$CREDENTIAL_JSON" > ${{ runner.workspace }}/.config/dart/pub-credentials.json
+          if [ -n "$XDG_CONFIG_HOME" ]; then
+            mkdir -p $XDG_CONFIG_HOME/dart
+            cp ${{ runner.workspace }}/.config/dart/pub-credentials.json $XDG_CONFIG_HOME/dart/pub-credentials.json
+          else
+            mkdir -p $HOME/.config/dart
+            cp ${{ runner.workspace }}/.config/dart/pub-credentials.json $HOME/.config/dart/pub-credentials.json
+          fi
+        env:
+          CREDENTIAL_JSON: ${{ secrets.CREDENTIAL_JSON }}
+          XDG_CONFIG_HOME: ${{ env.XDG_CONFIG_HOME }}
+
+      - name: Publish to pub.dev
+        run: dart pub publish -f
+
+      - name: Create release branch
+        uses: peterjgrainger/[email protected]
+        with:
+          branch: release/${{ github.event.release.tag_name }}
+          sha: '${{ github.event.pull_request.head.sha }}'
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/ci.yml .github/workflows/test.yml.github/workflows/ci.yml renamed to .github/workflows/test.yml

@@ -12,7 +12,7 @@ on:
 
 env:
   FLUTTER_CHANNEL: 'stable'
-  FLUTTER_VERSION: '3.10.2'
+  FLUTTER_VERSION: '3.13.4'
 
 jobs:
   build_example_android:

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.3.0
+* iOS: fix volume slider not shown when pressing physical buttons after `showSystemUI` is reset.
+* Deprecated: `showSystemUI` setter is deprecated and migrated to `updateShowSystemUI`.
+
 ## 1.2.7
 * Fixed audio session not activated with ambient state on iOS.
 

README.md

@@ -27,9 +27,10 @@ A Flutter plugin to control system volume and listen for volume changes on diffe
 
 #### Control System UI Visibility
 - Set to `true` to display system volume slider when changing volume.
-- This settings only works on Android and iOS.
+- This setting only works on Android and iOS.
+- Note: this setting doesn't control the volume slider invoked by physical buttons on Android.
 ```dart
-FlutterVolumeController.showSystemUI = true;
+await FlutterVolumeController.updateShowSystemUI(true);
 ```
 
 #### Get Volume
@@ -153,9 +154,13 @@ void dispose() {
   a rounded off value.
 
 #### Audio devices without volume control
-- On desktop platforms like Windows and Linux, you may encounter PlatformExceptions if the default 
+- On desktop platforms like Windows and Linux, you may encounter `PlatformException` if the default 
   audio device doesn't support volume control, like an external monitor.
 
+#### Controlling Android volume slider UI
+- Currently there is no trivial way to control the volume slider invoked by physical buttons on
+  Android in plugin level. You may override `FlutterActivity::onKeyDown` to customize the buttons action.
+
 ## Having Bugs?
 - This package is under active development. If you find any bug, please create an issue on Github.
 

example/.gitignore

@@ -31,6 +31,7 @@ migrate_working_dir/
 .pub-cache/
 .pub/
 /build/
+pubspec.lock
 
 # Web related
 lib/generated_plugin_registrant.dart

example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1300"
+   LastUpgradeVersion = "1430"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

example/ios/Runner/Info.plist

@@ -2,6 +2,8 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
+	<key>CADisableMinimumFrameDurationOnPhone</key>
+	<true/>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>$(DEVELOPMENT_LANGUAGE)</string>
 	<key>CFBundleDisplayName</key>
@@ -24,6 +26,8 @@
 	<string>$(FLUTTER_BUILD_NUMBER)</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
+	<key>UIApplicationSupportsIndirectInputEvents</key>
+	<true/>
 	<key>UILaunchStoryboardName</key>
 	<string>LaunchScreen</string>
 	<key>UIMainStoryboardFile</key>
@@ -43,9 +47,5 @@
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
 	<false/>
-	<key>CADisableMinimumFrameDurationOnPhone</key>
-	<true/>
-	<key>UIApplicationSupportsIndirectInputEvents</key>
-	<true/>
 </dict>
 </plist>

example/lib/main.dart

@@ -68,8 +68,8 @@ class _HomeState extends State<Home> {
               child: ElevatedButton(
                 child: const Text('Show or hide system ui'),
                 onPressed: () {
-                  FlutterVolumeController.showSystemUI =
-                      !FlutterVolumeController.showSystemUI;
+                  FlutterVolumeController.updateShowSystemUI(
+                      !FlutterVolumeController.showSystemUI);
                   _showSnackBar(
                     'Show system ui: ${FlutterVolumeController.showSystemUI}',
                   );