refactor(api): implement isRandomOrder function

Author: yoshinorin

__tests__/unit/api/api.test.ts

@@ -11,13 +11,12 @@ test("should returns 404 if path contains ignore chars", async () => {
   expect(response.status).toEqual(404);
 });
 
-
 describe("PaginationParams", () => {
   it("should accept valid PaginationParams object", () => {
     const params: PaginationParams = {
       page: 1,
       limit: 10,
-      order: Order.DESC,
+      order: Order.DESC
     };
 
     expect(params.page).toBe(1);
@@ -29,13 +28,13 @@ describe("PaginationParams", () => {
     const defaultParams: PaginationParams = {
       page: 1,
       limit: 20,
-      order: Order.DEFAULT,
+      order: Order.DEFAULT
     };
 
     const randomParams: PaginationParams = {
       page: 2,
       limit: 5,
-      order: Order.RANDOM,
+      order: Order.RANDOM
     };
 
     expect(defaultParams.order).toBe(Order.DEFAULT);
@@ -46,7 +45,7 @@ describe("PaginationParams", () => {
     const params: PaginationParams = {
       page: 1,
       limit: 10,
-      order: Order.DESC,
+      order: Order.DESC
     };
 
     expect(typeof params.page).toBe("number");
@@ -61,7 +60,7 @@ describe("PaginationParams", () => {
     const params: PaginationParams = {
       page: 1,
       limit: 10,
-      order: validOrder,
+      order: validOrder
     };
 
     expect(params.order).toBe(Order.DESC);

__tests__/unit/api/order.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { Order, getValidOrder } from "../../../src/api/order";
+import { Order, getValidOrder, isRandomOrder } from "../../../src/api/order";
 
 describe("Order", () => {
   it("should have correct enum values", () => {
@@ -51,3 +51,30 @@ describe("getValidOrder", () => {
     expect(getValidOrder("RANDOM")).toBe(Order.DEFAULT);
   });
 });
+
+describe("isRandomOrder", () => {
+  it("should return true when order is Order.RANDOM", () => {
+    const result = isRandomOrder(Order.RANDOM);
+    expect(result).toBe(true);
+  });
+
+  it("should return false when order is Order.DEFAULT", () => {
+    const result = isRandomOrder(Order.DEFAULT);
+    expect(result).toBe(false);
+  });
+
+  it("should return false when order is Order.DESC", () => {
+    const result = isRandomOrder(Order.DESC);
+    expect(result).toBe(false);
+  });
+
+  it("should work with getValidOrder function", () => {
+    const randomOrder = getValidOrder("random");
+    const descOrder = getValidOrder("desc");
+    const defaultOrder = getValidOrder("invalid");
+
+    expect(isRandomOrder(randomOrder)).toBe(true);
+    expect(isRandomOrder(descOrder)).toBe(false);
+    expect(isRandomOrder(defaultOrder)).toBe(false);
+  });
+});

src/api/order.ts

@@ -1,7 +1,7 @@
 export enum Order {
-  DEFAULT = 'default',
-  DESC = 'desc',
-  RANDOM = 'random'
+  DEFAULT = "default",
+  DESC = "desc",
+  RANDOM = "random"
 }
 
 export function getValidOrder(orderParam: string | undefined): Order {
@@ -14,3 +14,7 @@ export function getValidOrder(orderParam: string | undefined): Order {
       return Order.DEFAULT;
   }
 }
+
+export function isRandomOrder(order: Order): boolean {
+  return order === Order.RANDOM;
+}

src/app/articles/page.tsx

@@ -2,7 +2,7 @@
 
 import { headers } from "next/headers";
 import { fetchArticles } from "../../api";
-import { getValidOrder, Order } from "../../api/order";
+import { getValidOrder, isRandomOrder } from "../../api/order";
 import { Article, ArticleResponseWithCount } from "../../models/models";
 import { parseOrThrow, runWithHandleErrorIf } from "../handler";
 import { Renderer } from "./renderer";
@@ -18,7 +18,7 @@ export default async function Page(req: any) {
 async function handler(req: any) {
   const queryString = await req.searchParams;
   const order = getValidOrder(queryString.order);
-  const randomness = order === Order.RANDOM;
+  const randomness = isRandomOrder(order);
   const currentPage = queryString.p ? queryString.p : 1;
   const response: Response = await fetchArticles(
     await headers(),

src/app/page.tsx

@@ -16,7 +16,12 @@ export default async function Page(req: any) {
 }
 
 async function handler(req: any) {
-  const response: Response = await fetchArticles(await headers(), 1, 5, Order.DEFAULT);
+  const response: Response = await fetchArticles(
+    await headers(),
+    1,
+    5,
+    Order.DEFAULT
+  );
   const articlesResponseWithCount =
     await parseOrThrow<ArticleResponseWithCount>(response);
   const articles: Array<Article> = articlesResponseWithCount.articles.map(

src/app/tags/[...slug]/page.tsx

@@ -2,7 +2,7 @@
 
 import { headers } from "next/headers";
 import { fetchTag } from "../../../api";
-import { getValidOrder, Order } from "../../../api/order";
+import { getValidOrder, isRandomOrder } from "../../../api/order";
 import { Article, ArticleResponseWithCount } from "../../../models/models";
 import { parseOrThrow, runWithHandleErrorIf } from "../../handler";
 import { Renderer } from "./renderer";
@@ -21,7 +21,7 @@ async function handler(req: any) {
 
   const queryString = await req.searchParams;
   const order = getValidOrder(queryString.order);
-  const randomness = order === Order.RANDOM;
+  const randomness = isRandomOrder(order);
   const currentPage = queryString.p ? queryString.p : 1;
   const response: Response = await fetchTag(
     await headers(),