DateTimeWriter: write in native

Author: yosiat

ext/panko_serializer/panko_serializer.c

@@ -2,21 +2,72 @@
 
 #include "time_conversion.h"
 
-VALUE public_is_iso8601_time_string(VALUE klass, VALUE value) {
-  return is_iso8601_time_string(StringValuePtr(value)) ? Qtrue : Qfalse;
+static ID push_value_id;
+
+static VALUE datetime_writer_write(VALUE self, VALUE value, VALUE writer,
+                                   VALUE key) {
+  if (RB_TYPE_P(value, T_STRING)) {
+    const char* val = StringValuePtr(value);
+
+    // 'Z' in ISO8601 says it's UTC
+    if (val[strlen(val) - 1] == 'Z' && is_iso8601_time_string(val) == Qtrue) {
+      rb_funcall(writer, push_value_id, 2, value, key);
+      return Qtrue;
+    }
+
+    volatile VALUE iso8601_string = iso_ar_iso_datetime_string(val);
+    if (iso8601_string != Qnil) {
+      rb_funcall(writer, push_value_id, 2, iso8601_string, key);
+      return Qtrue;
+    }
+  }
+
+  return Qfalse;
 }
 
-VALUE public_iso_ar_iso_datetime_string(VALUE klass, VALUE value) {
-  return iso_ar_iso_datetime_string(StringValuePtr(value));
+// Helper function to safely get a constant if it exists
+static VALUE safe_const_get(VALUE parent, const char* name) {
+  if (rb_const_defined(parent, rb_intern(name))) {
+    return rb_const_get(parent, rb_intern(name));
+  }
+  return Qnil;
 }
 
 void Init_panko_serializer() {
-  VALUE mPanko = rb_define_module("Panko");
+  push_value_id = rb_intern("push_value");
 
-  rb_define_singleton_method(mPanko, "is_iso8601_time_string",
-                             public_is_iso8601_time_string, 1);
-  rb_define_singleton_method(mPanko, "iso_ar_iso_datetime_string",
-                             public_iso_ar_iso_datetime_string, 1);
+  VALUE mPanko = rb_define_module("Panko");
 
   panko_init_time(mPanko);
+
+  VALUE impl = safe_const_get(mPanko, "Impl");
+  if (NIL_P(impl)) {
+    printf("Not patching\n");
+    return;
+  }
+
+  VALUE attributes_writer = safe_const_get(impl, "AttributesWriter");
+  if (NIL_P(attributes_writer)) {
+    printf("Not patching\n");
+    return;
+  }
+
+  VALUE active_record = safe_const_get(attributes_writer, "ActiveRecord");
+  if (NIL_P(active_record)) {
+    printf("Not patching\n");
+    return;
+  }
+
+  VALUE values_writer = safe_const_get(active_record, "ValuesWriter");
+  if (NIL_P(values_writer)) {
+    printf("Not patching\n");
+    return;
+  }
+
+  VALUE cDateTimeWriter = safe_const_get(values_writer, "DateTimeWriter");
+  if (NIL_P(cDateTimeWriter)) {
+    printf("Not patching\n");
+  } else {
+    rb_define_method(cDateTimeWriter, "write", datetime_writer_write, 3);
+  }
 }

lib/panko/impl/attributes_writer/active_record/values_writer/datetime_writer.rb

@@ -3,19 +3,8 @@
 module Panko::Impl::AttributesWriter::ActiveRecord::ValuesWriter
   class DateTimeWriter
     def write(value, writer, key)
-      return false unless value.is_a?(String)
-
-      if value.end_with?("Z") && Panko.is_iso8601_time_string(value)
-        writer.push_value(value, key)
-        return true
-      end
-
-      iso8601_string = Panko.iso_ar_iso_datetime_string(value)
-      unless iso8601_string.nil?
-        writer.push_value(iso8601_string, key)
-        return true
-      end
-
+      # The actual implementation is in the native extension
+      # if there is no native extension, we will fallback to Rails implementation
       false
     end
   end