Add shared OMP roles and memory dream review (#136)

* add shared OMP roles and memory dream review

* address PR #136 review: accurate stale-duplicate reason wording + truncation regression test

---------

Co-authored-by: Kirill Korikov <11762090+yourconscience@users.noreply.github.com>

Author: yourconscience

agents/researcher.md

@@ -7,7 +7,10 @@ tools: [Read, Glob, Grep, Bash, WebFetch, WebSearch, Write]
 color: green
 codex:
   model: gpt-5.6-luna
-  model_reasoning_effort: medium
+  model_reasoning_effort: max
+omp:
+  model: gpt-5.6-luna
+  thinking-level: max
 ---
 
 You are a technical researcher. Your job is to investigate and report, not implement.

cmd/dotagents/agents.go

@@ -35,6 +35,7 @@ type agentRole struct {
 	Instructions string              `yaml:"-"`
 	Source       string              `yaml:"-"`
 	Codex        codexRoleOptions    `yaml:"codex"`
+	OMP          ompRoleOptions      `yaml:"omp"`
 	Droid        droidRoleOptions    `yaml:"droid"`
 	Opencode     opencodeRoleOptions `yaml:"opencode"`
 }
@@ -71,6 +72,10 @@ func (role *agentRole) UnmarshalYAML(value *yaml.Node) error {
 			if err := node.Decode(&role.Codex); err != nil {
 				return err
 			}
+		case "omp":
+			if err := node.Decode(&role.OMP); err != nil {
+				return err
+			}
 		case "droid":
 			if err := node.Decode(&role.Droid); err != nil {
 				return err
@@ -116,6 +121,11 @@ type codexRoleOptions struct {
 	ModelReasoningEffort string `yaml:"model_reasoning_effort"`
 }
 
+type ompRoleOptions struct {
+	Model         string `yaml:"model"`
+	ThinkingLevel string `yaml:"thinking-level"`
+}
+
 type droidRoleOptions struct {
 	Model           string   `yaml:"model"`
 	ReasoningEffort string   `yaml:"reasoning_effort"`

cmd/dotagents/agents_test.go

@@ -62,6 +62,53 @@ func TestRenderCodexAgentRoleEscapesControlCharacters(t *testing.T) {
 	}
 }
 
+func TestRenderOMPAgentRoleHonorsOverride(t *testing.T) {
+	role := agentRole{
+		Name:         "researcher",
+		Description:  "Find reliable evidence",
+		Model:        "opus",
+		Effort:       "high",
+		Instructions: "Compare the sources.",
+		OMP: ompRoleOptions{
+			Model:         "gpt-5.6-luna",
+			ThinkingLevel: "xhigh",
+		},
+	}
+
+	got := renderOMPAgentRole(role)
+	for _, want := range []string{
+		`name: "researcher"`,
+		"model:\n",
+		`- "gpt-5.6-luna"`,
+		`thinking-level: "xhigh"`,
+	} {
+		if !strings.Contains(got, want) {
+			t.Fatalf("rendered OMP role missing %q:\n%s", want, got)
+		}
+	}
+	if strings.Contains(got, `- "opus"`) || strings.Contains(got, "effort:") {
+		t.Fatalf("OMP role leaked Claude defaults into override:\n%s", got)
+	}
+}
+
+func TestRenderOMPAgentRoleFallsBackToCanonicalModel(t *testing.T) {
+	role := agentRole{
+		Name:         "reviewer",
+		Description:  "Reviews code",
+		Model:        "opus",
+		Effort:       "high",
+		Instructions: "Review carefully.",
+	}
+
+	got := renderOMPAgentRole(role)
+	if !strings.Contains(got, "model:\n") || !strings.Contains(got, `- "opus"`) {
+		t.Fatalf("OMP role did not fall back to canonical model:\n%s", got)
+	}
+	if strings.Contains(got, "thinking-level:") {
+		t.Fatalf("OMP role invented a thinking-level without an override:\n%s", got)
+	}
+}
+
 func TestRenderDroidAgentRoleMapsModelAndTools(t *testing.T) {
 	role := agentRole{
 		Name:         "builder",
@@ -173,6 +220,9 @@ model: sonnet
 effort: high
 tools: [Read, Grep]
 color: purple
+omp:
+  model: gpt-5.6-luna
+  thinking-level: xhigh
 ---
 
 Review the change.
@@ -207,10 +257,58 @@ Implement the change.
 	if len(role.Tools) != 2 || role.Tools[0] != "Read" || role.Tools[1] != "Grep" {
 		t.Fatalf("unexpected tools: %#v", role.Tools)
 	}
+	if role.OMP.Model != "gpt-5.6-luna" || role.OMP.ThinkingLevel != "xhigh" {
+		t.Fatalf("unexpected OMP options: %#v", role.OMP)
+	}
 	if filepath.Base(role.Source) != "reviewer.md" {
 		t.Fatalf("unexpected source: %q", role.Source)
 	}
 }
+
+func TestCanonicalResearcherRendersCodexAtMax(t *testing.T) {
+	repoRoot, err := filepath.Abs(filepath.Join("..", ".."))
+	if err != nil {
+		t.Fatal(err)
+	}
+	role, err := loadMarkdownAgentRole(filepath.Join(repoRoot, "agents", "researcher.md"))
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	got := renderCodexAgentRole(role)
+	for _, want := range []string{
+		`name = "researcher"`,
+		`model = "gpt-5.6-luna"`,
+		`model_reasoning_effort = "max"`,
+	} {
+		if !strings.Contains(got, want) {
+			t.Fatalf("canonical researcher Codex role missing %q:\n%s", want, got)
+		}
+	}
+}
+
+func TestCanonicalResearcherRendersOMPAtMaximum(t *testing.T) {
+	repoRoot, err := filepath.Abs(filepath.Join("..", ".."))
+	if err != nil {
+		t.Fatal(err)
+	}
+	role, err := loadMarkdownAgentRole(filepath.Join(repoRoot, "agents", "researcher.md"))
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	got := renderOMPAgentRole(role)
+	for _, want := range []string{
+		`name: "researcher"`,
+		`- "gpt-5.6-luna"`,
+		`thinking-level: "max"`,
+	} {
+		if !strings.Contains(got, want) {
+			t.Fatalf("canonical researcher OMP role missing %q:\n%s", want, got)
+		}
+	}
+}
+
 func TestLoadAgentRolesMarkdownRejectsMappingTools(t *testing.T) {
 	repoRoot := t.TempDir()
 	writeAgentsFixture(t, repoRoot, "invalid.md", `---

cmd/dotagents/omp_agent.go

@@ -14,14 +14,20 @@ var ompToolMapping = map[string]string{
 }
 
 func renderOMPAgentRole(role agentRole) string {
+	model := strings.TrimSpace(role.OMP.Model)
+	if model == "" {
+		model = strings.TrimSpace(role.Model)
+	}
+
 	var b strings.Builder
 	b.WriteString("---\n")
 	writeYAMLScalar(&b, "name", role.Name)
 	writeYAMLScalar(&b, "description", role.Description)
-	if model := strings.TrimSpace(role.Model); model != "" {
+	if model != "" {
 		b.WriteString("model:\n")
 		writeYAMLListItem(&b, model)
 	}
+	writeYAMLScalar(&b, "thinking-level", role.OMP.ThinkingLevel)
 	if tools := ompToolsFor(role.Tools); len(tools) > 0 {
 		b.WriteString("tools:\n")
 		for _, tool := range tools {

memory/README.md

@@ -28,6 +28,39 @@ session start. It does not invoke memsearch or persist raw transcripts.
 The memsearch tier registers the indexed SessionStart, Stop, and SessionEnd
 pipeline. Configure its vault through `~/.agents/memsearch.conf`.
 
+## Dream review
+
+Run the dream pass manually to find exact repeated preferences or corrections,
+duplicate session records, and conflicting copies:
+
+```bash
+python3 ~/.agents/memory/lib/basic_memory.py dream \
+  --output "$KNOWLEDGE_DIR/reviews/memory-dream-2026-08-19.json"
+```
+
+The output is a deterministic, review-only JSON artifact. The command reads
+complete marker-delimited records under `sessions/` plus exact duplicate facts
+in the legacy `sessions/knowledge.md` export. It does not scan
+`profile/USER.md`, edit canonical memory, archive records, or delete anything.
+The output path must be new and live under `$KNOWLEDGE_DIR/reviews/`.
+
+Candidates are deliberately conservative:
+
+- Repeated preferences and corrections require the same explicit statement in
+  at least two distinct session IDs.
+- A stale duplicate requires an identical session block (ignoring trailing
+  whitespace) outside its unique UTC-dated canonical file.
+- Legacy cleanup reports only exact facts repeated across distinct `## Sync`
+  records; it does not infer staleness from age.
+- Reused session IDs with differing content are reported as conflicts, without
+  choosing a survivor.
+- Assistant output, truncated statements, incomplete records, fuzzy semantic
+  matches, and age alone never produce candidates.
+
+Review the source coordinates and candidate IDs before making a separate,
+explicit edit to canonical memory. There is intentionally no apply or delete
+mode.
+
 ## Canonical paths
 
 The knowledge vault path is set in `~/.agents/memsearch.conf` as `KNOWLEDGE_DIR`.