Vectorize the particle deposition

Assume that we're depositing vector, and treat scalar fields
as a special case of vectors

Author: cphyc

yt/data_objects/index_subobjects/octree_subset.py

@@ -7,7 +7,6 @@
 from unyt import unyt_array
 
 import yt.geometry.particle_deposit as particle_deposit
-import yt.geometry.particle_deposit_vector as particle_deposit_vector
 import yt.geometry.particle_smooth as particle_smooth
 from yt.data_objects.selection_objects.data_selection_objects import (
     YTSelectionContainer,
@@ -176,10 +175,8 @@ def deposit(
         # Here we perform our particle deposition.
         if fields is None:
             fields = []
-        if vector_field:
-            cls = getattr(particle_deposit_vector, f"deposit_{method}", None)
-        else:
-            cls = getattr(particle_deposit, f"deposit_{method}", None)
+
+        cls = getattr(particle_deposit, f"deposit_{method}", None)
         if cls is None:
             raise YTParticleDepositionNotImplemented(method)
         nz = self.nz

yt/frontends/artio/_artio_caller.pyx

@@ -1560,7 +1560,7 @@ cdef class ARTIORootMeshContainer:
         nf = len(fields)
         cdef np.float64_t[::cython.view.indirect, ::1] field_pointers
         if nf > 0: field_pointers = OnceIndirect(fields)
-        cdef np.float64_t[:] field_vals = np.empty(nf, dtype="float64")
+        cdef np.float64_t[:, :] field_vals = np.empty((nf, 1), dtype="float64")
         cdef np.ndarray[np.uint8_t, ndim=1, cast=True] mask
         mask = self.mask(selector, -1)
         cdef np.ndarray[np.int64_t, ndim=1] domain_ind
@@ -1583,7 +1583,7 @@ cdef class ARTIORootMeshContainer:
         cdef np.int64_t offset
         for i in range(positions.shape[0]):
             for j in range(nf):
-                field_vals[j] = field_pointers[j][i]
+                field_vals[j,0] = field_pointers[j][i]
             for j in range(3):
                 pos[j] = positions[i, j]
                 coords[j] = <int>((pos[j] - self.DLE[j])/self.dds[j])
@@ -1598,7 +1598,7 @@ cdef class ARTIORootMeshContainer:
                          offset, pos, field_vals, sfc)
             if pdeposit.update_values == 1:
                 for j in range(nf):
-                    field_pointers[j][i] = field_vals[j]
+                    field_pointers[j][i] = field_vals[j,0]
 
 cdef class SFCRangeSelector(SelectorObject):
 

yt/geometry/particle_deposit.pxd

@@ -144,5 +144,5 @@ cdef class ParticleDepositOperation:
     cdef public int update_values
     cdef int process(self, int dim[3], int ipart, np.float64_t left_edge[3],
                      np.float64_t dds[3], np.int64_t offset,
-                     np.float64_t ppos[3], np.float64_t[:] fields,
+                     np.float64_t ppos[3], np.float64_t[:, :] fields,
                      np.int64_t domain_ind) except -1 nogil