[#29405] YSQL: Make yb_make_all_ddl_statements_incrementing a test GUC

Summary:
Previously, {D46348} introduced the `yb_make_all_ddl_statements_incrementing` GUC, which when enabled, makes all DDL statements increment the catalog version. This could potentially cause DDLs to fail that previously succeeded due to catalog version mismatch. For example, if a workload involves running multiple `CREATE TABLE` statements in parallel, this would previously be okay, but if `yb_make_all_ddl_statements_incrementing` was set to `true`, some of these `CREATE TABLE` DDLs would fail.

This diff makes `yb_make_all_ddl_statements_incrementing` into a test GUC to discourage customers from setting it without understanding the consequences. We do this with the following two changes:

  - Add the `yb_test` prefix to the GUC. `yb_make_all_ddl_statements_incrementing` -> `yb_test_make_all_ddl_statements_incrementing`
  - Change the GUC's group from `CUSTOM_OPTIONS` to `DEVELOPER_OPTIONS`.

Test Plan:
```
./yb_build.sh release --java-test 'org.yb.pgsql.TestPgRegressMisc#makeAllDdlStatementsIncrementing'
```

Reviewers: myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D48415

Author: kai-franz

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgRegressMisc.java

@@ -89,7 +89,7 @@ public void makeAllDdlStatementsIncrementing() throws Exception {
         Collections.emptyMap(),
         Collections.singletonMap(
             "ysql_pg_conf_csv",
-            "yb_make_all_ddl_statements_incrementing=true"
+            "yb_test_make_all_ddl_statements_incrementing=true"
         )
     );
     runPgRegressTest("yb_misc_catalog_version_increment_schedule");

src/postgres/src/backend/utils/cache/catcache.c

@@ -1931,11 +1931,11 @@ YbAllowNegativeCacheEntries(int cache_id,
 							bool implicit_prefetch_entries)
 {
 	/*
-	 * If yb_make_all_ddl_statements_incrementing is true, negative cache entries
+	 * If yb_test_make_all_ddl_statements_incrementing is true, negative cache entries
 	 * are always okay, because if a negative entry needs to be invalidated, the
 	 * catalog version will be incremented.
 	 */
-	if (yb_make_all_ddl_statements_incrementing)
+	if (yb_test_make_all_ddl_statements_incrementing)
 		return true;
 
 	switch (cache_id)

src/postgres/src/backend/utils/misc/guc.c

@@ -3676,14 +3676,14 @@ static struct config_bool ConfigureNamesBool[] =
 	},
 
 	{
-		{"yb_make_all_ddl_statements_incrementing", PGC_SIGHUP, CUSTOM_OPTIONS,
+		{"yb_test_make_all_ddl_statements_incrementing", PGC_SIGHUP, DEVELOPER_OPTIONS,
 			gettext_noop("When set, all DDL statements will cause the "
 						 "catalog version to increment. This mainly affects "
 						 "CREATE commands such as CREATE TABLE, CREATE VIEW, "
 						 "and CREATE SEQUENCE."),
 			NULL
 		},
-		&yb_make_all_ddl_statements_incrementing,
+		&yb_test_make_all_ddl_statements_incrementing,
 		false,
 		NULL, NULL, NULL
 	},
@@ -7500,7 +7500,7 @@ static const char *const YbDbAdminVariables[] = {
 	"yb_binary_restore",
 	"yb_speculatively_execute_pl_statements",
 	"yb_whitelist_extra_statements_for_pl_speculative_execution",
-	"yb_make_all_ddl_statements_incrementing",
+	"yb_test_make_all_ddl_statements_incrementing",
 };
 
 

src/postgres/src/backend/utils/misc/pg_yb_utils.c

@@ -2249,7 +2249,7 @@ bool		yb_enable_parallel_scan_colocated = true;
 bool		yb_enable_parallel_scan_hash_sharded = false;
 bool		yb_enable_parallel_scan_range_sharded = false;
 bool		yb_enable_parallel_scan_system = false;
-bool        yb_make_all_ddl_statements_incrementing = false;
+bool        yb_test_make_all_ddl_statements_incrementing = false;
 
 /* DEPRECATED */
 bool		yb_enable_advisory_locks = true;
@@ -4148,10 +4148,10 @@ YbGetDdlMode(PlannedStmt *pstmt, ProcessUtilityContext context,
 	if (yb_make_next_ddl_statement_nonbreaking)
 		is_breaking_change = false;
 	/*
-	 * If yb_make_all_ddl_statements_incrementing is true, we should be incrementing
+	 * If yb_test_make_all_ddl_statements_incrementing is true, we should be incrementing
 	 * the catalog version for all DDL statements.
 	 */
-	if (yb_make_all_ddl_statements_incrementing)
+	if (yb_test_make_all_ddl_statements_incrementing)
 		is_version_increment = true;
 	/*
 	 * If yb_make_next_ddl_statement_nonincrementing is true, then no DDL statement

src/postgres/src/include/pg_yb_utils.h

@@ -800,7 +800,7 @@ extern bool	yb_enable_parallel_scan_system;
 /*
  * If set to true, all DDL statements will cause the catalog version to increment.
  */
-extern bool yb_make_all_ddl_statements_incrementing;
+extern bool yb_test_make_all_ddl_statements_incrementing;
 
 typedef struct YBUpdateOptimizationOptions
 {

src/postgres/src/test/regress/expected/yb.orig.catalog_version_increment.out

@@ -1,4 +1,4 @@
--- Test yb_make_all_ddl_statements_incrementing GUC.
+-- Test yb_test_make_all_ddl_statements_incrementing GUC.
 -- All of the following DDL statements should increment current_version.
 \set template1_db_oid 1
 \set db_oid 'CASE WHEN (select count(*) from pg_yb_catalog_version) = 1 THEN :template1_db_oid ELSE (SELECT oid FROM pg_database WHERE datname = \'yugabyte\') END'
@@ -118,7 +118,7 @@ DROP TABLE temp_to_drop_guc;
            10012 |                 10000
 (1 row)
 
--- Additional DDLs that should increment under yb_make_all_ddl_statements_incrementing=true.
+-- Additional DDLs that should increment under yb_test_make_all_ddl_statements_incrementing=true.
 CREATE OPERATOR ==# (
     LEFTARG = int,
     RIGHTARG = int,

src/postgres/src/test/regress/sql/yb.orig.catalog_version_increment.sql

@@ -1,4 +1,4 @@
--- Test yb_make_all_ddl_statements_incrementing GUC.
+-- Test yb_test_make_all_ddl_statements_incrementing GUC.
 -- All of the following DDL statements should increment current_version.
 \set template1_db_oid 1
 \set db_oid 'CASE WHEN (select count(*) from pg_yb_catalog_version) = 1 THEN :template1_db_oid ELSE (SELECT oid FROM pg_database WHERE datname = \'yugabyte\') END'
@@ -59,7 +59,7 @@ ALTER TABLE temp_to_drop_guc ADD COLUMN val int;
 DROP TABLE temp_to_drop_guc;
 :display_catalog_version;
 
--- Additional DDLs that should increment under yb_make_all_ddl_statements_incrementing=true.
+-- Additional DDLs that should increment under yb_test_make_all_ddl_statements_incrementing=true.
 CREATE OPERATOR ==# (
     LEFTARG = int,
     RIGHTARG = int,

src/postgres/src/test/regress/yb_misc_catalog_version_increment_schedule

@@ -2,7 +2,7 @@
 #
 ####################################################################################################
 # This testsuite includes tests that test the catalog version increment when
-# yb_make_all_ddl_statements_incrementing is set to true. This needs to be a
+# yb_test_make_all_ddl_statements_incrementing is set to true. This needs to be a
 # separate schedule because the flag requires a cluster restart to apply.
 # The tests in this schedule are not ported from PostgreSQL original tests.
 ####################################################################################################