-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
area/ysqlYugabyte SQL (YSQL)Yugabyte SQL (YSQL)kind/enhancementThis is an enhancement of an existing featureThis is an enhancement of an existing featurepriority/mediumMedium priority issueMedium priority issuestatus/awaiting-triageIssue awaiting triageIssue awaiting triage
Description
Jira Link: DB-19803
Description
The JsonReader class is a very old class and poorly designed. It claims
that it has no choice but to expose rapidjson internals, but that's not
true. All the Extract* functions should be static as they have nothing
to do with member variables. The Extract* functions take pointers for
filling results rather than returning Result<...>s. Protobuf-related
functions don't need to be implemented here and can instead be defined
in a separate utility.
Replace the whole class with a brand new class JsonDocument.
Issue Type
kind/enhancement
Warning: Please confirm that this issue does not contain any sensitive information
- I confirm this issue does not contain any sensitive information.
Metadata
Metadata
Assignees
Labels
area/ysqlYugabyte SQL (YSQL)Yugabyte SQL (YSQL)kind/enhancementThis is an enhancement of an existing featureThis is an enhancement of an existing featurepriority/mediumMedium priority issueMedium priority issuestatus/awaiting-triageIssue awaiting triageIssue awaiting triage