Skip to content

[YSQL] replace JsonReader with new JsonDocument #29944

@jasonyb

Description

@jasonyb

Jira Link: DB-19803

Description

The JsonReader class is a very old class and poorly designed. It claims
that it has no choice but to expose rapidjson internals, but that's not
true. All the Extract* functions should be static as they have nothing
to do with member variables. The Extract* functions take pointers for
filling results rather than returning Result<...>s. Protobuf-related
functions don't need to be implemented here and can instead be defined
in a separate utility.

Replace the whole class with a brand new class JsonDocument.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions