fix(region): support stop for change vm config (#24815)

Author: ioito

pkg/apis/compute/guests.go

@@ -891,6 +891,10 @@ type ServerChangeConfigInput struct {
 	// 内存大小, 1024M, 1G
 	VmemSize string `json:"vmem_size"`
 
+	// 是否强制关机
+	// 若虚拟机不支持开机调整配置, 则需要指定此参数为true, 强制关机后, 再调整配置, 再启动虚拟机
+	ForceStop bool `json:"force_stop"`
+
 	// 调整完配置后是否自动启动
 	AutoStart bool `json:"auto_start"`
 

pkg/compute/guestdrivers/aliyun.go

@@ -103,8 +103,8 @@ func (self *SAliyunGuestDriver) IsAllowSaveImageOnRunning() bool {
 	return true
 }
 
-func (self *SAliyunGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return []string{api.VM_READY}, nil
+func (self *SAliyunGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return false, nil
 }
 
 func (self *SAliyunGuestDriver) GetDeployStatus() ([]string, error) {

pkg/compute/guestdrivers/aws.go

@@ -191,8 +191,8 @@ func (self *SAwsGuestDriver) GetRebuildRootStatus() ([]string, error) {
 	return []string{api.VM_READY, api.VM_RUNNING}, nil
 }
 
-func (self *SAwsGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return []string{api.VM_READY}, nil
+func (self *SAwsGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return false, nil
 }
 
 func (self *SAwsGuestDriver) GetDeployStatus() ([]string, error) {

pkg/compute/guestdrivers/azure.go

@@ -102,8 +102,22 @@ func (self *SAzureGuestDriver) IsRebuildRootSupportChangeUEFI() bool {
 	return false
 }
 
-func (self *SAzureGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return []string{api.VM_READY, api.VM_RUNNING}, nil
+// azureInstanceTypeSupportsResizeWhileRunning 部分 Azure SKU 在开机状态下变更规格易失败，此处做保守判断
+func azureInstanceTypeSupportsResizeWhileRunning(instanceType string) bool {
+	if len(instanceType) == 0 {
+		return true
+	}
+	if strings.HasPrefix(instanceType, "Basic_") || strings.HasPrefix(instanceType, "Standard_A") {
+		return false
+	}
+	return true
+}
+
+func (self *SAzureGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	if guest == nil || azureInstanceTypeSupportsResizeWhileRunning(guest.InstanceType) {
+		return true, nil
+	}
+	return false, nil
 }
 
 func (self *SAzureGuestDriver) GetDeployStatus() ([]string, error) {

pkg/compute/guestdrivers/baidu.go

@@ -121,8 +121,8 @@ func (self *SBaiduGuestDriver) GetAttachDiskStatus() ([]string, error) {
 	return []string{api.VM_READY, api.VM_RUNNING}, nil
 }
 
-func (self *SBaiduGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return []string{api.VM_READY}, nil
+func (self *SBaiduGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return false, nil
 }
 
 func (self *SBaiduGuestDriver) GetDeployStatus() ([]string, error) {

pkg/compute/guestdrivers/baremetals.go

@@ -123,8 +123,8 @@ func (self *SBaremetalGuestDriver) GetRebuildRootStatus() ([]string, error) {
 	return []string{api.VM_READY, api.VM_ADMIN}, nil
 }
 
-func (self *SBaremetalGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return nil, httperrors.NewUnsupportOperationError("Cannot change config for baremtal")
+func (self *SBaremetalGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return false, httperrors.NewUnsupportOperationError("Cannot change config for baremtal")
 }
 
 func (self *SBaremetalGuestDriver) GetDeployStatus() ([]string, error) {

pkg/compute/guestdrivers/base.go

@@ -175,8 +175,8 @@ func (drv *SBaseGuestDriver) IsRebuildRootSupportChangeUEFI() bool {
 	return true
 }
 
-func (drv *SBaseGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return []string{}, fmt.Errorf("This Guest driver dose not implement GetChangeInstanceTypeStatus")
+func (drv *SBaseGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return false, fmt.Errorf("This Guest driver dose not implement IsChangeInstanceTypeWhileRunningSupported")
 }
 
 func (drv *SBaseGuestDriver) ValidateDetachDisk(ctx context.Context, userCred mcclient.TokenCredential, guest *models.SGuest, disk *models.SDisk) error {

pkg/compute/guestdrivers/cas.go

@@ -100,8 +100,8 @@ func (self *SCasGuestDriver) GetRebuildRootStatus() ([]string, error) {
 	return []string{api.VM_READY}, nil
 }
 
-func (self *SCasGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return []string{api.VM_READY}, nil
+func (self *SCasGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return false, nil
 }
 
 func (self *SCasGuestDriver) GetDeployStatus() ([]string, error) {

pkg/compute/guestdrivers/cloudpods-baremetals.go

@@ -123,8 +123,8 @@ func (self *SCloudpodsBaremetalGuestDriver) GetRebuildRootStatus() ([]string, er
 	return []string{api.VM_READY, api.VM_ADMIN}, nil
 }
 
-func (self *SCloudpodsBaremetalGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return nil, httperrors.NewUnsupportOperationError("Cannot change config for baremtal")
+func (self *SCloudpodsBaremetalGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return false, httperrors.NewUnsupportOperationError("Cannot change config for baremtal")
 }
 
 func (self *SCloudpodsBaremetalGuestDriver) GetDeployStatus() ([]string, error) {

pkg/compute/guestdrivers/cloudpods-esxi.go

@@ -209,8 +209,8 @@ func (self *SCloudpodsESXiGuestDriver) GetAttachDiskStatus() ([]string, error) {
 	return []string{api.VM_READY, api.VM_RUNNING}, nil
 }
 
-func (self *SCloudpodsESXiGuestDriver) GetChangeInstanceTypeStatus() ([]string, error) {
-	return []string{api.VM_READY, api.VM_RUNNING}, nil
+func (self *SCloudpodsESXiGuestDriver) IsChangeInstanceTypeWhileRunningSupported(guest *models.SGuest) (bool, error) {
+	return true, nil
 }
 
 func (self *SCloudpodsESXiGuestDriver) CanKeepDetachDisk() bool {