Skip to content

implementation problems here #7

@Ledzy

Description

@Ledzy

I found two problems about the code.
First, the reconstruction loss should be L1 loss instead of L2, according to cycleGAN's paper.
Second, the generator and discriminator should update simutaneously, while in the code it firstly update discriminator and then use updated discriminator to update generator, which is wrong.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions