Traktor S4MK3: New preference for FX button order

Optionally, make "filter" the first quickeffect instead of button 1.

This better aligns with how I think about the buttons -- Filter as the primary quickeffect, and the others as extra optional effects.

Signed-off-by: Owen Williams <owilliams@mixxx.org>

Author: ywwg

res/controllers/Traktor Kontrol S4 MK3.hid.xml

@@ -240,6 +240,15 @@
                     This option is useful if you don't use samplers and would like to access a set of predefined beatloop rolls. Beat size can be customized individually.
                 </description>
             </option>
+            <option
+                variable="filterIsFirstQuickEffect"
+                type="boolean"
+                default="false"
+                label="Assign the first QuickEffect to the :hwbtn:`FILTER` button instead of button :hwbtn:`1`">
+                <description>
+                    This option is useful if you are used to Filter being the primary quickeffect and have it at the top of your QuickEfect list.
+                </description>
+            </option>
             <option
                 variable="defaultPadLayout"
                 type="enum"

res/controllers/Traktor-Kontrol-S4-MK3.js

@@ -141,6 +141,8 @@ const MixerControlsMixAuxOnShift = !!engine.getSetting("mixerControlsMicAuxOnShi
 // Default: false
 const UseBeatloopRollInsteadOfSampler = !!engine.getSetting("useBeatloopRollInsteadOfSampler");
 
+const FilterIsFirstQuickEffect = !!engine.getSetting("filterIsFirstQuickEffect");
+
 // Predefined beatlooproll sizes.
 const BeatLoopRolls = [
     engine.getSetting("beatLoopRollsSize1") || 1/8,
@@ -1506,14 +1508,32 @@ class Mixer extends ComponentContainer {
             {inByte: 8, inBit: 7},
         ];
         this.fxSelects = [];
-        // FX SELECT buttons: Filter, 1, 2, 3, 4
-        for (const i of [0, 1, 2, 3, 4]) {
-            this.fxSelects[i] = new FXSelect(
-                Object.assign(fxSelectsInputs[i], {
-                    number: i + 1,
+        if (FilterIsFirstQuickEffect) {
+            // FX SELECT buttons: Filter, 1, 2, 3, 4
+            this.fxSelects[4] = new FXSelect(
+                Object.assign(fxSelectsInputs[4], {
+                    number: 1,
                     mixer: this,
                 })
             );
+            for (const i of [0, 1, 2, 3]) {
+                this.fxSelects[i] = new FXSelect(
+                    Object.assign(fxSelectsInputs[i], {
+                        number: i + 2,
+                        mixer: this,
+                    })
+                );
+            }
+        } else {
+            // FX SELECT buttons: 1, 2, 3, 4, Filter
+            for (const i of [0, 1, 2, 3, 4]) {
+                this.fxSelects[i] = new FXSelect(
+                    Object.assign(fxSelectsInputs[i], {
+                        number: i + 1,
+                        mixer: this,
+                    })
+                );
+            }
         }
 
         const quickEffectInputs = [