Skip to content

Commit 6f54463

Browse files
committed
Fix up add-on binding
1 parent ed40fa1 commit 6f54463

File tree

2 files changed

+28
-15
lines changed

2 files changed

+28
-15
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ dependencies {
104104
implementation 'com.github.zacharee:CollapsiblePreferenceCategory:75d1f8b5c5'
105105
implementation 'com.github.zacharee:Android-ExpandableTextView:74f653343d'
106106
implementation 'com.github.zacharee:ComposeIntroSlider:d273cf5734'
107-
implementation 'com.github.zacharee:SystemUITunerSystemSettings:0f4f6a0c2d'
107+
implementation 'com.github.zacharee:SystemUITunerSystemSettings:6c498b7783'
108108

109109
implementation 'com.bugsnag:bugsnag-android:6.1.0'
110110
implementation 'com.getkeepsafe.relinker:relinker:1.4.5'

app/src/main/java/com/zacharee1/systemuituner/util/SettingsUtils.kt

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,17 @@ fun Context.getSetting(type: SettingsType, key: String?, def: Any? = null): Stri
184184
}
185185
}
186186
settingsAddon.hasService -> {
187-
settingsAddon.binder?.readSetting(
188-
type.toLibraryType(),
189-
key
190-
)
187+
if (settingsAddon.binderAvailable) {
188+
settingsAddon.binder?.readSetting(
189+
type.toLibraryType(),
190+
key
191+
)
192+
} else {
193+
Log.e("SystemUITuner", "Add-on exists but isn't bound.")
194+
BugsnagUtils.leaveBreadcrumb("Add-on exists but isn't bound for reading.")
195+
ReadSettingFailActivity.start(this, type, key)
196+
null
197+
}
191198
}
192199
else -> {
193200
ReadSettingFailActivity.start(this, type, key)
@@ -268,17 +275,23 @@ private fun Context.writeSystem(key: String?, value: Any?): Boolean {
268275
null
269276
}
270277
}
271-
settingsAddon.hasService && settingsAddon.binderAvailable -> {
272-
val result = settingsAddon.binder?.writeSetting(
273-
com.zacharee1.systemuituner.systemsettingsaddon.library.SettingsType.SYSTEM,
274-
key,
275-
value?.toString()
276-
)
277-
278-
if (result == true) {
279-
true
278+
settingsAddon.hasService -> {
279+
if (settingsAddon.binderAvailable) {
280+
val result = settingsAddon.binder?.writeSetting(
281+
com.zacharee1.systemuituner.systemsettingsaddon.library.SettingsType.SYSTEM,
282+
key,
283+
value?.toString()
284+
)
285+
286+
if (result == true) {
287+
true
288+
} else {
289+
null
290+
}
280291
} else {
281-
null
292+
Log.e("SystemUITuner", "Add-on not bound")
293+
BugsnagUtils.leaveBreadcrumb("Add-on exists but isn't bound for writing.")
294+
false
282295
}
283296
}
284297
else -> {

0 commit comments

Comments
 (0)