fix(cli): generate api-resource resolves objectName placeholders (wheels-dev#2566)

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>

Author: wheels-bot[bot]

CHANGELOG.md

@@ -152,6 +152,7 @@ All historical references to "CFWheels" in this changelog have been preserved fo
 
 ### Fixed
 
+- `wheels generate api-resource` now produces a controller with resolved identifiers instead of literal `#objectNamePlural#` / `#objectNameSingular#` placeholders. The framework snippet at `app/snippets/ApiControllerContent.txt` was still using the legacy hash-token form that the CLI's `Templates.processTemplate()` does not substitute, while the CLI-bundled copy already used the pipe-delimited `|ObjectNamePlural|` / `|ObjectNameSingular|` tokens it understands. Aligned the framework-level snippet with the CLI-bundled one. (#2468)
 - Framework dev pages (`/wheels/guides`, `/wheels/info`, `/wheels/migrator`, `/wheels/packages`, error screens) now render Semantic UI icons instead of empty bordered squares. The dev layouts inline `semantic.min.css` into a `<style>` block, so its relative URLs to `themes/default/assets/fonts/icons.woff2` resolved against the page URL and 404'd — every `<i class="...icon">` rendered as the fallback square. `_header.cfm` and `_header_simple.cfm` now read the woff2 once at application scope, base64-encode it, and emit a `@font-face` override after the inlined Semantic CSS. Initialization uses double-checked locking on `application.wheels.iconsFontDataUri` so concurrent first-requests can't read an intermediate empty value. (#2563)
 - Debug bar Tools → Packages page now lists packages available from the `wheels-dev/wheels-packages` registry in fresh apps generated with `wheels new`. The previous gate (`FileExists("/cli/lucli/services/packages/Registry.cfc")`) silently returned an empty list because user apps don't ship the CLI alongside the framework. The registry reader now lives at `vendor/wheels/services/packages/{Registry,HttpClient,ManifestCache}.cfc` and ships with every generated app. The registry list stays scoped to the standalone Tools → Packages page; the inline debug-bar Environment panel shows installed packages only, so the bar stays compact and doesn't trigger a registry walk on every dev-mode page load. (#2530)
 - `Registry.fetchManifest()` now validates that a manifest contains a non-empty `versions` array before returning, throwing `Wheels.Packages.RegistryMalformed` instead of letting a downstream `local.m.versions[ArrayLen(...)]` access crash with an unhandled `Expression` error. The per-package skip-on-malformed catch in `listAll()` now actually catches every malformed shape, so the Tools → Packages page degrades gracefully when the registry serves a partial manifest. Mirrored into the CLI's `cli/lucli/services/packages/Registry.cfc` to keep both copies in sync. (#2530)

app/snippets/ApiControllerContent.txt

@@ -6,71 +6,71 @@
     }
 
     /**
-     * GET /#objectNamePlural#
-     * Returns a list of all #objectNamePlural#
+     * GET /|ObjectNamePlural|
+     * Returns a list of all |ObjectNamePlural|
      */
     function index() {
-        local.#objectNamePlural# = model("|ObjectNameSingular|").findAll();
-        renderWith(data={ #objectNamePlural#=local.#objectNamePlural# });
+        local.|ObjectNamePlural| = model("|ObjectNameSingular|").findAll();
+        renderWith(data={ |ObjectNamePlural|=local.|ObjectNamePlural| });
     }
 
     /**
-     * GET /#objectNamePlural#/:key
-     * Returns a specific #objectNameSingular# by ID
+     * GET /|ObjectNamePlural|/:key
+     * Returns a specific |ObjectNameSingular| by ID
      */
     function show() {
-        local.#objectNameSingular# = model("|ObjectNameSingular|").findByKey(params.key);
+        local.|ObjectNameSingular| = model("|ObjectNameSingular|").findByKey(params.key);
 
-        if (IsObject(local.#objectNameSingular#)) {
-            renderWith(data={ #objectNameSingular#=local.#objectNameSingular# });
+        if (IsObject(local.|ObjectNameSingular|)) {
+            renderWith(data={ |ObjectNameSingular|=local.|ObjectNameSingular| });
         } else {
             renderWith(data={ error="Record not found" }, status=404);
         }
     }
 
     /**
-     * POST /#objectNamePlural#
-     * Creates a new #objectNameSingular#
+     * POST /|ObjectNamePlural|
+     * Creates a new |ObjectNameSingular|
      */
     function create() {
-        local.#objectNameSingular# = model("|ObjectNameSingular|").new(params.#objectNameSingular#);
+        local.|ObjectNameSingular| = model("|ObjectNameSingular|").new(params.|ObjectNameSingular|);
 
-        if (local.#objectNameSingular#.save()) {
-            renderWith(data={ #objectNameSingular#=local.#objectNameSingular# }, status=201);
+        if (local.|ObjectNameSingular|.save()) {
+            renderWith(data={ |ObjectNameSingular|=local.|ObjectNameSingular| }, status=201);
         } else {
-            renderWith(data={ error="Validation failed", errors=local.#objectNameSingular#.allErrors() }, status=422);
+            renderWith(data={ error="Validation failed", errors=local.|ObjectNameSingular|.allErrors() }, status=422);
         }
     }
 
     /**
-     * PUT /#objectNamePlural#/:key
-     * Updates an existing #objectNameSingular#
+     * PUT /|ObjectNamePlural|/:key
+     * Updates an existing |ObjectNameSingular|
      */
     function update() {
-        local.#objectNameSingular# = model("|ObjectNameSingular|").findByKey(params.key);
+        local.|ObjectNameSingular| = model("|ObjectNameSingular|").findByKey(params.key);
 
-        if (IsObject(local.#objectNameSingular#)) {
-            local.#objectNameSingular#.update(params.#objectNameSingular#);
+        if (IsObject(local.|ObjectNameSingular|)) {
+            local.|ObjectNameSingular|.update(params.|ObjectNameSingular|);
 
-            if (local.#objectNameSingular#.hasErrors()) {
-                renderWith(data={ error="Validation failed", errors=local.#objectNameSingular#.allErrors() }, status=422);
+            if (local.|ObjectNameSingular|.hasErrors()) {
+                renderWith(data={ error="Validation failed", errors=local.|ObjectNameSingular|.allErrors() }, status=422);
             } else {
-                renderWith(data={ #objectNameSingular#=local.#objectNameSingular# });
+                renderWith(data={ |ObjectNameSingular|=local.|ObjectNameSingular| });
             }
         } else {
             renderWith(data={ error="Record not found" }, status=404);
         }
     }
 
     /**
-     * DELETE /#objectNamePlural#/:key
-     * Deletes a #objectNameSingular#
+     * DELETE /|ObjectNamePlural|/:key
+     * Deletes a |ObjectNameSingular|
      */
     function delete() {
-        local.#objectNameSingular# = model("|ObjectNameSingular|").findByKey(params.key);
+        local.|ObjectNameSingular| = model("|ObjectNameSingular|").findByKey(params.key);
 
-        if (IsObject(local.#objectNameSingular#)) {
-            local.#objectNameSingular#.delete();
+        if (IsObject(local.|ObjectNameSingular|)) {
+            local.|ObjectNameSingular|.delete();
             renderWith(data={}, status=204);
         } else {
             renderWith(data={ error="Record not found" }, status=404);

vendor/wheels/tests/specs/cli/ApiControllerSnippetSpec.cfc

@@ -0,0 +1,49 @@
+/**
+ * Regression: app/snippets/ApiControllerContent.txt is consumed by the CLI
+ * Templates service (cli/lucli/services/Templates.cfc) when `wheels generate
+ * api-resource` is run. The processor only replaces pipe-delimited tokens
+ * (e.g. |ObjectNameSingular|, |ObjectNamePlural|); the legacy ##objectName##
+ * style is NOT substituted and lands verbatim in generated controllers.
+ *
+ * Issue #2468: the framework snippet still uses the legacy ##objectName##
+ * tokens, so generated API controllers contain unresolved placeholders.
+ */
+component extends="wheels.WheelsTest" {
+
+	function run() {
+
+		describe("app/snippets/ApiControllerContent.txt", function() {
+
+			it("uses pipe-delimited tokens the CLI Templates processor understands", function() {
+				var path = expandPath("/app/snippets/ApiControllerContent.txt");
+				expect(fileExists(path)).toBeTrue("Snippet missing at " & path);
+
+				var content = fileRead(path);
+
+				// Hash literals must be doubled in CFML strings — these strings
+				// represent the legacy, unresolved token forms.
+				var legacyPlural = "##" & "objectNamePlural" & "##";
+				var legacySingular = "##" & "objectNameSingular" & "##";
+
+				expect(content contains legacyPlural).toBeFalse(
+					"Snippet still contains legacy token " & legacyPlural
+					& " — CLI Templates.processTemplate() doesn't substitute this form."
+				);
+				expect(content contains legacySingular).toBeFalse(
+					"Snippet still contains legacy token " & legacySingular
+					& " — CLI Templates.processTemplate() doesn't substitute this form."
+				);
+
+				expect(content contains "|ObjectNamePlural|").toBeTrue(
+					"Snippet should use |ObjectNamePlural| — the token Templates.processTemplate() replaces."
+				);
+				expect(content contains "|ObjectNameSingular|").toBeTrue(
+					"Snippet should use |ObjectNameSingular| — the token Templates.processTemplate() replaces."
+				);
+			});
+
+		});
+
+	}
+
+}