`getRectanglePoints` needs better type return

[tpoisseau]

react-roi/src/utilities/box.ts

Line 390 in 2049776

export function getRectanglePoints(box: CommittedBox): Point[] {

For non breaking change I suggest to return a tuple [topLeft: Point, topRight: Point, bottomRight: Point, bottomLeft: Point].

If breaking change OK, return an object.

[stropitek]

If breaking change OK, return an object.

Array is better as it allows to iterate on the points (which we do in some places)

[targos]

Take care with the naming. There is rotation so the points are not necessarily in the order from top-left to bottom-left.

[stropitek]

indeed, unnamed tuple is maybe better

[tpoisseau]

Take care with the naming. There is rotation so the points are not necessarily in the order from top-left to bottom-left.

If you have better name I take it. We can consider it is the names of the points before the rotation.
When rotation handle is shown, it's on, it's always on "top" segment. If it can help for referential and find better names.

indeed, unnamed tuple is maybe better

The points are returned in a certain order, they should be identified by names.

I don't know, is there any standard naming for the four points of a rectangle in mathematics / geometry ?

Maybe a, b, c, d and use tsdoc to illustrate how they are connected ?