Skip to content

Commit f71d45f

Browse files
committed
fix: proxy client trace events should all use the same time units
track all in usec to be consistent Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
1 parent 64c3597 commit f71d45f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

proxy/proxy.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1872,13 +1872,13 @@ func injectClientTraceByTag(ctx *context, t time.Time, req *http.Request, span o
18721872
span.SetTag(ClientTraceDNS, time.Since(ctx.clientTraceTime).Microseconds())
18731873
},
18741874
ConnectDone: func(string, string, error) {
1875-
span.SetTag(ClientTraceConnect, time.Since(ctx.clientTraceTime).Milliseconds())
1875+
span.SetTag(ClientTraceConnect, time.Since(ctx.clientTraceTime).Microseconds())
18761876
},
18771877
TLSHandshakeDone: func(tls.ConnectionState, error) {
18781878
span.SetTag(ClientTraceTLS, time.Since(ctx.clientTraceTime).Microseconds())
18791879
},
18801880
GotConn: func(httptrace.GotConnInfo) {
1881-
span.SetTag(ClientTraceGetConn, time.Since(ctx.clientTraceTime).Nanoseconds())
1881+
span.SetTag(ClientTraceGetConn, time.Since(ctx.clientTraceTime).Microseconds())
18821882
},
18831883
Got100Continue: func() {
18841884
span.SetTag(ClientTraceGot100Continue, time.Since(ctx.clientTraceTime).Microseconds())

0 commit comments

Comments
 (0)