Fix PR review comments, update CI, and add Playwright test suite

Address all Copilot review comments across PRs 169-171:
- Fix worker requestId response guard (always respond when requestId present)
- Fix MessageBus falsy response handling and add request timeout
- Fix CascadeAPI duplicate meta tag and evaluate() concurrent call safety
- Fix ConsoleManager + worker multi-arg console.log capture
- Clear console on each evaluation in EditorManager
- Fix OpenSCAD transpiler: cylinder defaults, square dynamic centering,
  for/range negative step handling, multi-child transform shape removal
- Fix Mirror bug (shapes vs shapes[shapeIndex])
- Pass fuzzValue to BRepAlgoAPI boolean operations
- Fix argCache reference-breaking reassignment in ShapeToMesh and Text3D
- Add sceneOptions undefined guard in CascadeView
- Fix String.fromCharCode stack overflow for large projects
- Fix duplicate event listeners on re-initialization
- Use execFileSync instead of execSync to avoid shell injection

Update CI from deprecated GitHub Actions v2 to v4 with Playwright.
Add comprehensive Playwright test suite (42 tests covering startup,
API, primitives, transforms, booleans, operations, export, GUI, console).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: zalo

.github/workflows/ci.yml

@@ -2,48 +2,42 @@ name: CascadeStudio - End To End Test
 
 on:
   push:
+  pull_request:
 
 jobs:
   test:
     name: End to End Test
-    runs-on: windows-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout Repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           lfs: true
 
-      - name: Cache Node Modules
-        uses: actions/cache@v2
-        env:
-          cache-name: cache-node-modules
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
         with:
-          # npm cache files are stored in `~/.npm` on Linux/macOS
-          path: ~/.npm
-          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-build-${{ env.cache-name }}-
-            ${{ runner.os }}-build-
-            ${{ runner.os }}-
-
-      - name: Install Testing Node Modules
-        run: |
-          cd test
-          npm install
-
-      - name: Run Server and Tests
-        run: |
-          start python "test/server.py"
-          cd test
-          npx folio --param screenshotOnFailure --param browserName=chromium
-
-      - name: Upload Failing Screenshots
-        uses: actions/upload-artifact@v2
-        if: failure()
-        with:
-          name: Screenshots
-          path: test/test-results
+          node-version: 20
+          cache: 'npm'
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Install Playwright Browsers
+        run: npx playwright install --with-deps chromium
 
-      - name: Where to go from here
+      - name: Build Project
+        run: npm run build
+
+      - name: Run Tests
+        run: npx playwright test
+
+      - name: Upload Test Results
+        uses: actions/upload-artifact@v4
         if: failure()
-        run: echo "~~~*** Test failed!  See the README.md in CascadeStudio/test for more information ***~~~"
+        with:
+          name: playwright-report
+          path: |
+            playwright-report/
+            test-results/
+          retention-days: 7

js/CADWorker/CascadeStudioMainWorker.js

@@ -41,9 +41,10 @@ class CascadeStudioWorker {
     const realLog = this.realConsoleLog;
     const realError = this.realConsoleError;
 
-    console.log = function (message) {
+    console.log = function (...args) {
+      const message = args.map(a => typeof a === 'string' ? a : JSON.stringify(a)).join(' ');
       setTimeout(() => { postMessage({ type: "log", payload: message }); }, 0);
-      realLog.apply(console, arguments);
+      realLog.apply(console, args);
     };
 
     console.error = function (err, url, line, colno, errorObj) {
@@ -116,7 +117,7 @@ class CascadeStudioWorker {
       // Route incoming messages to registered handlers
       onmessage = function (e) {
         let response = self.messageHandlers[e.data.type](e.data.payload);
-        if (response) {
+        if (response !== undefined || e.data.requestId) {
           const msg = { "type": e.data.type, payload: response };
           if (e.data.requestId) { msg.requestId = e.data.requestId; }
           postMessage(msg);

js/CADWorker/CascadeStudioShapeToMesh.js

@@ -69,7 +69,7 @@ class CascadeStudioMesher {
       CascadeStudioMesher.forEachFace(shape, (faceIndex, myFace) => {
         let aLocation = new oc.TopLoc_Location_1();
         let myT = oc.BRep_Tool.Triangulation(myFace, aLocation, 0 /* Poly_MeshPurpose_NONE */);
-        if (myT.IsNull()) { console.error("Encountered Null Face!"); self.argCache = {}; return; }
+        if (myT.IsNull()) { console.error("Encountered Null Face!"); for (let k in self.argCache) delete self.argCache[k]; return; }
 
         let this_face = {
           vertex_coord: [],

js/CADWorker/CascadeStudioStandardLibrary.js

@@ -123,7 +123,7 @@ function Text3D(text, size, height, fontName) {
 
   let textArgs = JSON.stringify(arguments);
   let curText = self.CacheOp(arguments, "Text3D", () => {
-    if (self.loadedFonts[fontName] === undefined) { self.argCache = {}; console.log("Font not loaded or found yet!  Try again..."); return; }
+    if (self.loadedFonts[fontName] === undefined) { for (let k in self.argCache) delete self.argCache[k]; console.log("Font not loaded or found yet!  Try again..."); return; }
     let textFaces = [];
     let commands = self.loadedFonts[fontName].getPath(text, 0, 0, size).commands;
     for (let idx = 0; idx < commands.length; idx++) {
@@ -413,7 +413,7 @@ function Mirror(vector, shapes, keepOriginal) {
     } else if (shapes.length >= 1) {
       let newMirroring = [];
       for (let shapeIndex = 0; shapeIndex < shapes.length; shapeIndex++) {
-        newMirroring.push(new self.oc.BRepBuilderAPI_Transform_2(shapes, mirrorTransform, false).Shape());
+        newMirroring.push(new self.oc.BRepBuilderAPI_Transform_2(shapes[shapeIndex], mirrorTransform, false).Shape());
       }
       return newMirroring;
     }
@@ -456,6 +456,8 @@ function Union(objectsToJoin, keepObjects, fuzzValue, keepEdges) {
       for (let i = 0; i < objectsToJoin.length; i++) {
         if (i > 0) {
           let combinedFuse = new self.oc.BRepAlgoAPI_Fuse_3(combined, objectsToJoin[i], new self.oc.Message_ProgressRange_1());
+          combinedFuse.SetFuzzyValue(fuzzValue);
+          combinedFuse.Build(new self.oc.Message_ProgressRange_1());
           combined = combinedFuse.Shape();
         }
       }
@@ -486,6 +488,8 @@ function Difference(mainBody, objectsToSubtract, keepObjects, fuzzValue, keepEdg
       for (let i = 0; i < objectsToSubtract.length; i++) {
         if (!objectsToSubtract[i] || objectsToSubtract[i].IsNull()) { console.error("Tool in Difference is null!"); }
         let differenceCut = new self.oc.BRepAlgoAPI_Cut_3(difference, objectsToSubtract[i], new self.oc.Message_ProgressRange_1());
+        differenceCut.SetFuzzyValue(fuzzValue);
+        differenceCut.Build(new self.oc.Message_ProgressRange_1());
         difference = differenceCut.Shape();
       }
     }
@@ -527,6 +531,8 @@ function Intersection(objectsToIntersect, keepObjects, fuzzValue, keepEdges) {
       for (let i = 0; i < objectsToIntersect.length; i++) {
         if (i > 0) {
           let intersectedCommon = new self.oc.BRepAlgoAPI_Common_3(intersected, objectsToIntersect[i], new self.oc.Message_ProgressRange_1());
+          intersectedCommon.SetFuzzyValue(fuzzValue);
+          intersectedCommon.Build(new self.oc.Message_ProgressRange_1());
           intersected = intersectedCommon.Shape();
         }
       }

js/MainPage/CascadeAPI.js

@@ -10,14 +10,17 @@ class CascadeAPI {
     this._app = app;
   }
 
-  /** Install the API on window and add discovery meta tag. */
+  /** Install the API on window and update discovery meta tag. */
   install() {
     window.CascadeAPI = this;
-    // Add meta tag for agent discovery
-    const meta = document.createElement('meta');
-    meta.name = 'cascade-api';
+    // Update existing meta tag or create one for agent discovery
+    let meta = document.querySelector('meta[name="cascade-api"]');
+    if (!meta) {
+      meta = document.createElement('meta');
+      meta.name = 'cascade-api';
+      document.head.appendChild(meta);
+    }
     meta.content = 'window.CascadeAPI';
-    document.head.appendChild(meta);
   }
 
   // --- Code Management ---
@@ -34,17 +37,25 @@ class CascadeAPI {
 
   /** Evaluate the current code and return a Promise that resolves when generation is complete. */
   evaluate() {
-    return new Promise((resolve) => {
-      // Listen for generation completion
+    if (this._evaluatePromise) { return this._evaluatePromise; }
+    this._evaluatePromise = new Promise((resolve) => {
+      // Wrap the existing handler to detect completion
       const originalHandler = this._app.messageBus.handlers["combineAndRenderShapes"];
       this._app.messageBus.on("combineAndRenderShapes", (payload) => {
-        // Restore original handler and call it
-        this._app.messageBus.on("combineAndRenderShapes", originalHandler);
+        // Restore original handler first
+        if (originalHandler) {
+          this._app.messageBus.on("combineAndRenderShapes", originalHandler);
+        } else {
+          this._app.messageBus.off("combineAndRenderShapes");
+        }
+        // Call original handler
         if (originalHandler) originalHandler(payload);
+        this._evaluatePromise = null;
         resolve();
       });
       this._app.editor.evaluateCode(false);
     });
+    return this._evaluatePromise;
   }
 
   // --- Results ---

js/MainPage/CascadeMain.js

@@ -141,14 +141,18 @@ class CascadeStudioApp {
       });
     }
 
-    // Resize the layout when the browser resizes
-    const updateLayoutSize = () => {
+    // Resize the layout when the browser resizes (remove old listeners first)
+    if (this._updateLayoutSize) {
+      window.removeEventListener('resize', this._updateLayoutSize);
+      window.removeEventListener('orientationchange', this._updateLayoutSize);
+    }
+    this._updateLayoutSize = () => {
       const h = window.innerHeight - document.getElementById('topnav').offsetHeight;
       this.myLayout.setSize(window.innerWidth, h);
     };
-    window.addEventListener('resize', updateLayoutSize);
-    window.addEventListener('orientationchange', updateLayoutSize);
-    requestAnimationFrame(updateLayoutSize);
+    window.addEventListener('resize', this._updateLayoutSize);
+    window.addEventListener('orientationchange', this._updateLayoutSize);
+    requestAnimationFrame(this._updateLayoutSize);
 
     // Register startup callback from the CAD Worker
     this.messageBus.on("startupCallback", () => {
@@ -293,7 +297,12 @@ class CascadeStudioApp {
   /** Encode a string to a base64+compressed version. Uses fflate. */
   static encode(string) {
     const compressed = deflateSync(strToU8(string));
-    const binaryStr = String.fromCharCode(...compressed);
+    // Build binary string in chunks to avoid stack overflow with large data
+    let binaryStr = '';
+    const chunkSize = 8192;
+    for (let i = 0; i < compressed.length; i += chunkSize) {
+      binaryStr += String.fromCharCode.apply(null, compressed.subarray(i, i + chunkSize));
+    }
     return encodeURIComponent(btoa(binaryStr));
   }
 

js/MainPage/CascadeView.js

@@ -147,6 +147,7 @@ class CascadeEnvironment {
     messageBus.on("combineAndRenderShapes", ([[facelist, edgelist], sceneOptions]) => {
       window.workerWorking = false;
       if (!facelist) { return; }
+      if (!sceneOptions) { sceneOptions = {}; }
 
       // The old mainObject is dead! Long live the mainObject!
       this.environment.scene.remove(this.mainObject);

js/MainPage/ConsoleManager.js

@@ -97,13 +97,17 @@ class ConsoleManager {
     this._realConsoleLog = console.log;
     const self = this;
 
-    console.log = function (message) {
+    console.log = function (...args) {
       let messageText;
-      if (message !== undefined) {
-        messageText = JSON.stringify(message, ConsoleManager._circularReplacer());
-        if (messageText.startsWith('"')) { messageText = messageText.slice(1, -1); }
+      if (args.length === 0) {
+        messageText = "";
       } else {
-        messageText = "undefined";
+        messageText = args.map(arg => {
+          if (arg === undefined) return "undefined";
+          let s = JSON.stringify(arg, ConsoleManager._circularReplacer());
+          if (s && s.startsWith('"')) { s = s.slice(1, -1); }
+          return s;
+        }).join(' ');
       }
 
       self.logs.push(messageText);
@@ -115,7 +119,7 @@ class ConsoleManager {
       newline.innerHTML = ">  " + messageText;
       self._consoleContainer.appendChild(newline);
       self._consoleContainer.parentElement.scrollTop = self._consoleContainer.parentElement.scrollHeight;
-      self._realConsoleLog.apply(console, arguments);
+      self._realConsoleLog.apply(console, args);
     };
   }
 

js/MainPage/EditorManager.js

@@ -97,7 +97,8 @@ class EditorManager {
     let newCode = this.editor.getValue();
     monaco.editor.setModelMarkers(this.editor.getModel(), 'test', []);
 
-    // Refresh the GUI Panel
+    // Clear console and refresh the GUI Panel
+    this._app.console.clear();
     this._app.gui.reset();
     this._app.viewport.clearTransformHandles();
 

js/MainPage/MessageBus.js

@@ -23,7 +23,7 @@ class MessageBus {
       // Route to registered handler
       if (type in this._handlers) {
         let response = this._handlers[type](payload);
-        if (response) {
+        if (response !== undefined) {
           this._worker.postMessage({ type, payload: response });
         }
       }
@@ -50,11 +50,18 @@ class MessageBus {
   }
 
   /** Send a message and return a Promise that resolves with the response.
-   *  Requires the worker to propagate requestId back. */
-  request(type, payload) {
+   *  Requires the worker to propagate requestId back. Times out after 30s. */
+  request(type, payload, timeoutMs = 30000) {
     const requestId = this._nextRequestId++;
-    return new Promise((resolve) => {
-      this._pendingRequests[requestId] = resolve;
+    return new Promise((resolve, reject) => {
+      const timer = setTimeout(() => {
+        delete this._pendingRequests[requestId];
+        reject(new Error(`MessageBus request '${type}' timed out after ${timeoutMs}ms`));
+      }, timeoutMs);
+      this._pendingRequests[requestId] = (result) => {
+        clearTimeout(timer);
+        resolve(result);
+      };
       this._worker.postMessage({ type, payload, requestId });
     });
   }