Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

Align with Gateway contract errors #555

@isaacdecoded

Description

@isaacdecoded

We need to align the transaction sender with the InputVerification error names/parameters:

error CoprocessorAlreadyVerified(uint256 zkProofId, address txSender, address signer);

error CoprocessorAlreadyRejected(uint256 zkProofId, address txSender, address signer);

This change was discussed in this PR but in the end we included the txSender address as parameter in the errors and used the names CoprocessorAlreadyVerified/CoprocessorAlreadyRejected instead of CoprocessorSignerAlreadyVerified/CoprocessorSignerAlreadyRejected

OTOH, regarding this discussion in this PR, we are introducing other error name/parameter changes that should be aligned also:

  • In ICiphertextCommits.sol:
    • CoprocessorTxSenderAlreadyAdded -> error CoprocessorAlreadyAdded(bytes32 ctHandle, address txSender)
  • In IMultichainAcl.sol:
    • CoprocessorAlreadyAllowed -> error CoprocessorAlreadyAllowedPublicDecrypt(bytes32 ctHandle, address txSender) or error CoprocessorAlreadyAllowedAccount(bytes32 ctHandle, address account, address txSender) (we have now specific custom errors for each use case)
    • CoprocessorAlreadyDelegated -> error CoprocessorAlreadyDelegated( uint256 chainId, DelegationAccounts delegationAccounts, address[] contractAddresses, address txSender )

cc @goshawk-3 @dartdart26 @RomanBredehoft

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions