chore(kms-connector): improve error handling (#798)

* chore(kms-connector): improve error handling

* chore(kms-connector): configurable reverted tx tracing

Author: eudelins-zama

kms-connector/Cargo.lock

@@ -28,10 +28,11 @@ tfhe = "=1.3.2"
 actix-web = "=4.11.0"
 alloy = { version = "=1.0.9", default-features = false, features = [
     "essentials",
-    "reqwest-rustls-tls",
-    "std",
+    "provider-debug-api",
     "provider-ws",
+    "reqwest-rustls-tls",
     "signer-aws",
+    "std",
 ] }
 anyhow = { version = "=1.0.98", default-features = false }
 async-trait = { version = "=0.1.88", default-features = false }

kms-connector/Cargo.toml

@@ -82,6 +82,10 @@ private_key = "8da4ef21b864d2cc526dbdb2a120bd2874c36c9d0a1fb7f8c63d7f7a8b41de8f"
 # ENV: KMS_CONNECTOR_TX_RETRY_INTERVAL_MS
 # tx_retry_interval = 100
 
+# Boolean to enable tracing of reverted transactions, using `debug_trace_transaction` RPC call (optional, defaults to true)
+# ENV: KMS_CONNECTOR_TRACE_REVERTED_TX
+# trace_reverted_tx = true
+
 # The gas multiplier percentage after each transaction attempt (optional, defaults to 130%)
 # ENV: KMS_CONNECTOR_GAS_MULTIPLIER_PERCENT
 # gas_multiplier_percent = 130

kms-connector/config/tx-sender.toml

@@ -24,6 +24,7 @@ tracing.workspace = true
 connector-utils = { workspace = true, features = ["tests"] }
 rstest.workspace = true
 serial_test.workspace = true
+serde_json.workspace = true
 tempfile.workspace = true
 tokio-stream.workspace = true
 toml.workspace = true

kms-connector/crates/tx-sender/Cargo.toml

@@ -35,6 +35,8 @@ pub struct Config {
     pub tx_retries: u8,
     /// The interval between transaction retries.
     pub tx_retry_interval: Duration,
+    /// Enable tracing of reverted transactions.
+    pub trace_reverted_tx: bool,
     /// The batch size for KMS Core response processing.
     pub responses_batch_size: u8,
     /// The gas multiplier percentage after each transaction attempt.
@@ -110,6 +112,7 @@ impl Config {
             wallet,
             tx_retries: raw_config.tx_retries,
             tx_retry_interval,
+            trace_reverted_tx: raw_config.trace_reverted_tx,
             responses_batch_size: raw_config.responses_batch_size,
             gas_multiplier_percent: raw_config.gas_multiplier_percent,
             task_limit: raw_config.task_limit,
@@ -164,6 +167,7 @@ mod tests {
             env::remove_var("KMS_CONNECTOR_RESPONSES_BATCH_SIZE");
             env::remove_var("KMS_CONNECTOR_TX_RETRIES");
             env::remove_var("KMS_CONNECTOR_TX_RETRY_INTERVAL_MS");
+            env::remove_var("KMS_CONNECTOR_TRACE_REVERTED_TX");
             env::remove_var("KMS_CONNECTOR_GAS_MULTIPLIER_PERCENT");
         }
     }
@@ -249,6 +253,7 @@ mod tests {
             env::set_var("KMS_CONNECTOR_RESPONSES_BATCH_SIZE", "20");
             env::set_var("KMS_CONNECTOR_TX_RETRIES", "5");
             env::set_var("KMS_CONNECTOR_TX_RETRY_INTERVAL_MS", "200");
+            env::set_var("KMS_CONNECTOR_TRACE_REVERTED_TX", "false");
             env::set_var("KMS_CONNECTOR_GAS_MULTIPLIER_PERCENT", "180");
         }
 
@@ -270,6 +275,7 @@ mod tests {
         assert_eq!(config.responses_batch_size, 20);
         assert_eq!(config.tx_retries, 5);
         assert_eq!(config.tx_retry_interval, Duration::from_millis(200));
+        assert!(!config.trace_reverted_tx);
         assert_eq!(config.gas_multiplier_percent, 180);
 
         cleanup_env_vars();

kms-connector/crates/tx-sender/src/core/config/parsed.rs

@@ -29,6 +29,8 @@ pub struct RawConfig {
     pub tx_retries: u8,
     #[serde(default = "default_tx_retry_interval_ms")]
     pub tx_retry_interval_ms: u64,
+    #[serde(default = "default_trace_reverted_tx")]
+    pub trace_reverted_tx: bool,
     #[serde(default = "default_responses_batch_size")]
     pub responses_batch_size: u8,
     #[serde(default = "default_gas_multiplier_percent")]
@@ -57,12 +59,16 @@ fn default_tx_retry_interval_ms() -> u64 {
     100
 }
 
+fn default_trace_reverted_tx() -> bool {
+    true
+}
+
 fn default_responses_batch_size() -> u8 {
     10
 }
 
 fn default_gas_multiplier_percent() -> usize {
-    130 // 130% gas increase by default
+    300 // 300% gas increase by default
 }
 
 impl DeserializeRawConfig for RawConfig {}
@@ -93,6 +99,7 @@ impl Default for RawConfig {
             aws_kms_config: None,
             tx_retries: default_tx_retries(),
             tx_retry_interval_ms: default_tx_retry_interval_ms(),
+            trace_reverted_tx: default_trace_reverted_tx(),
             responses_batch_size: default_responses_batch_size(),
             gas_multiplier_percent: default_gas_multiplier_percent(),
             task_limit: default_task_limit(),