Skip to content

Commit 250d5f8

Browse files
committed
fix(coprocessor): address review noise and typos
1 parent 60014a8 commit 250d5f8

File tree

3 files changed

+8
-18
lines changed

3 files changed

+8
-18
lines changed

coprocessor/README.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,14 @@ Usage: tfhe_worker [OPTIONS]
7474
Options:
7575
--run-bg-worker
7676
Run the background worker
77-
--worker-polling-interval-ms <WORKER_POLLING_INTERVAL_MS>
78-
Polling interval for the background worker to fetch jobs [default: 1000]
7977
--generate-fhe-keys
8078
Generate fhe keys and exit
8179
--work-items-batch-size <WORK_ITEMS_BATCH_SIZE>
82-
Work items batch size [default: 100]
83-
--dependence-chains-per-batch <DEPENDENCE_CHAINS_PER_BATCH>
84-
Number of dependence chains to fetch per worker [default: 20]
80+
Work items batch size [default: 10]
8581
--tenant-key-cache-size <TENANT_KEY_CACHE_SIZE>
8682
Tenant key cache size [default: 32]
8783
--coprocessor-fhe-threads <COPROCESSOR_FHE_THREADS>
88-
Coprocessor FHE processing threads [default: 32]
84+
Coprocessor FHE processing threads [default: 8]
8985
--tokio-threads <TOKIO_THREADS>
9086
Tokio Async IO threads [default: 4]
9187
--pg-pool-max-connections <PG_POOL_MAX_CONNECTIONS>
@@ -94,8 +90,6 @@ Options:
9490
Prometheus metrics server address [default: 0.0.0.0:9100]
9591
--database-url <DATABASE_URL>
9692
Postgres database url. If unspecified DATABASE_URL environment variable is used
97-
--service-name <SERVICE_NAME>
98-
tfhe-worker service name in OTLP traces [default: tfhe-worker]
9993
```
10094

10195
```bash

coprocessor/docs/getting_started/fhevm/coprocessor/configuration.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,14 @@ Usage: coprocessor [OPTIONS]
1313
Options:
1414
--run-bg-worker
1515
Run the background worker
16-
--worker-polling-interval-ms <WORKER_POLLING_INTERVAL_MS>
17-
Polling interval for the background worker to fetch jobs [default: 1000]
1816
--generate-fhe-keys
1917
Generate fhe keys and exit
2018
--work-items-batch-size <WORK_ITEMS_BATCH_SIZE>
21-
Work items batch size [default: 100]
22-
--dependence-chains-per-batch <DEPENDENCE_CHAINS_PER_BATCH>
23-
Number of dependence chains to fetch per worker [default: 20]
19+
Work items batch size [default: 10]
2420
--tenant-key-cache-size <TENANT_KEY_CACHE_SIZE>
2521
Tenant key cache size [default: 32]
2622
--coprocessor-fhe-threads <COPROCESSOR_FHE_THREADS>
27-
Coprocessor FHE processing threads [default: 32]
23+
Coprocessor FHE processing threads [default: 8]
2824
--tokio-threads <TOKIO_THREADS>
2925
Tokio Async IO threads [default: 4]
3026
--pg-pool-max-connections <PG_POOL_MAX_CONNECTIONS>
@@ -34,7 +30,7 @@ Options:
3430
--database-url <DATABASE_URL>
3531
Postgres database url. If unspecified DATABASE_URL environment variable is used
3632
--service-name <SERVICE_NAME>
37-
tfhe-worker service name in OTLP traces [default: tfhe-worker]
33+
Coprocessor service name in OTLP traces [default: coprocessor]
3834
-h, --help
3935
Print help
4036
-V, --version

coprocessor/fhevm-engine/tfhe-worker/benches/dex.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ async fn schedule_dex(
404404
false,
405405
)
406406
.await?;
407-
let numer = next_handle(&mut handle_counter);
407+
let numerator = next_handle(&mut handle_counter);
408408
utils::insert_tfhe_event(
409409
&listener_db,
410410
&mut tx,
@@ -415,7 +415,7 @@ async fn schedule_dex(
415415
lhs: amount,
416416
rhs: pool_out,
417417
scalarByte: scalar_flag(false),
418-
result: numer,
418+
result: numerator,
419419
})),
420420
),
421421
tx_id,
@@ -430,7 +430,7 @@ async fn schedule_dex(
430430
tx_id,
431431
tfhe_event(TfheContractEvents::FheDiv(TfheContract::FheDiv {
432432
caller,
433-
lhs: numer,
433+
lhs: numerator,
434434
rhs: denom,
435435
scalarByte: scalar_flag(false),
436436
result: quote,

0 commit comments

Comments
 (0)