fix(test-suite): run random tests in all PRs and use default parameters for keygen (#1391)

Author: melanciani

.github/workflows/test-suite-e2e-tests.yml

@@ -187,6 +187,11 @@ jobs:
         run: |
           ./fhevm-cli test delegate-user-decryption
 
+      - name: Random operators test (subset)
+        working-directory: test-suite/fhevm
+        run: |
+          ./fhevm-cli test random-subset
+
       - name: Show logs on test failure
         working-directory: test-suite/fhevm
         if: always()

test-suite/fhevm/docker-compose/gateway-sc-docker-compose.yml

@@ -72,8 +72,11 @@ services:
         - type=gha,mode=max
     env_file:
       - ../env/staging/.env.gateway-sc.local
+    # Using test parameters (--params-type 1) is currently not possible at it can make the random
+    # tests fail with a high probability (1/2 chance), so we instead use default parameters (--params-type 0).
+    # See https://github.com/zama-ai/fhevm-internal/issues/685
     command:
-      - npx hardhat task:triggerKeygen --params-type 1
+      - npx hardhat task:triggerKeygen --params-type 0
     depends_on:
       gateway-sc-add-pausers:
         condition: service_completed_successfully
@@ -94,8 +97,11 @@ services:
         - type=gha,mode=max
     env_file:
       - ../env/staging/.env.gateway-sc.local
+    # Using test parameters (--params-type 1) is currently not possible for keygen (see above), and
+    # CRS parameters must be of the same type as the keygen parameters.
+    # See https://github.com/zama-ai/fhevm-internal/issues/685
     command:
-      - npx hardhat task:triggerCrsgen --params-type 1 --max-bit-length 2048
+      - npx hardhat task:triggerCrsgen --params-type 0 --max-bit-length 2048
     depends_on:
       gateway-sc-trigger-keygen:
         condition: service_completed_successfully

test-suite/fhevm/fhevm-cli

@@ -58,7 +58,7 @@ function usage {
   echo
   echo -e "${BOLD}${LIGHT_BLUE}Commands:${RESET}"
   echo -e "  ${YELLOW}deploy${RESET} ${CYAN}[--build]${RESET}    WIP: Deploy the full fhevm stack (optionally rebuild images)"
-  echo -e "  ${YELLOW}test${RESET} ${CYAN}[TYPE]${RESET}         Run tests (input-proof|user-decryption|public-decryption|erc20|debug)"
+  echo -e "  ${YELLOW}test${RESET} ${CYAN}[TYPE]${RESET}         Run tests (input-proof|user-decryption|public-decryption|delegate-user-decryption|random|random-subset|operators|erc20|debug)"
   echo -e "  ${YELLOW}upgrade${RESET} ${CYAN}[SERVICE]${RESET}   Upgrade specific service (host|gateway|connector|coprocessor|relayer|test-suite)"
   echo -e "  ${YELLOW}clean${RESET}               Remove all containers and volumes"
   echo -e "  ${YELLOW}logs${RESET} ${CYAN}[SERVICE]${RESET}      View logs for a specific service"
@@ -216,6 +216,10 @@ case $COMMAND in
           log_message="${LIGHT_BLUE}${BOLD}[TEST] RANDOM OPERATORS${RESET}"
           docker_args+=("-g" "generate and decrypt|generating rand in reverting sub-call|upper bound and decrypt")
           ;;
+        random-subset)
+          log_message="${LIGHT_BLUE}${BOLD}[TEST] RANDOM OPERATORS (SUBSET)${RESET}"
+          docker_args+=("-g" "64 bits generate and decrypt|generating rand in reverting sub-call|64 bits generate with upper bound and decrypt")
+          ;;
         debug)
           echo -e "${LIGHT_BLUE}${BOLD}[DEBUG] Starting debug session...${RESET}"
           docker exec -it fhevm-test-suite-e2e-debug bash