Skip to content

Commit 4b646c6

Browse files
committed
chore(gateway-contracts): take reviews into account
1 parent 9a902bb commit 4b646c6

File tree

3 files changed

+27
-29
lines changed

3 files changed

+27
-29
lines changed

gateway-contracts/contracts/CiphertextCommits.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import "./shared/UUPSUpgradeableEmptyProxy.sol";
1313
import "./shared/GatewayConfigChecks.sol";
1414
import "./shared/Pausable.sol";
1515
import "./libraries/HandleOps.sol";
16-
import { CoprocessorContexts } from "./CoprocessorContexts.sol";
1716
import { ContextChecks } from "./shared/ContextChecks.sol";
17+
1818
/**
1919
* @title CiphertextCommits smart contract
2020
* @dev See {ICiphertextCommits}.

gateway-contracts/contracts/CoprocessorContexts.sol

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -233,35 +233,33 @@ contract CoprocessorContexts is ICoprocessorContexts, Ownable2StepUpgradeable, U
233233
function refreshCoprocessorContextStatuses() external virtual whenNotPaused {
234234
CoprocessorContextsStorage storage $ = _getCoprocessorContextsStorage();
235235

236-
// If there is a pre-activation coprocessor context, then check if it is time to activate it
236+
// Check if there is a pre-activation coprocessor context and if it is time to activate it
237237
// and thus suspend the current active coprocessor context
238238
uint256 preActivationContextId = $.coprocessorContextLifecycle.preActivationContextId;
239-
if (preActivationContextId != 0) {
240-
if (block.number >= $.coprocessorContextActivationBlockNumber[preActivationContextId]) {
241-
uint256 activeContextId = getActiveCoprocessorContextId();
242-
243-
// Define the deactivation block number for the current active coprocessor context
244-
uint256 deactivatedBlockNumber = block.number +
245-
$.coprocessorContextSuspendedBlockPeriod[activeContextId];
246-
$.coprocessorContextDeactivatedBlockNumber[activeContextId] = deactivatedBlockNumber;
247-
248-
// Set the current active coprocessor context to the suspended state
249-
ContextLifecycle.setSuspended($.coprocessorContextLifecycle, activeContextId);
250-
emit SuspendCoprocessorContext(activeContextId, deactivatedBlockNumber);
251-
252-
// Set the new active coprocessor context
253-
ContextLifecycle.setActive($.coprocessorContextLifecycle, preActivationContextId);
254-
emit ActivateCoprocessorContext(preActivationContextId);
255-
}
239+
if (
240+
preActivationContextId != 0 &&
241+
block.number >= $.coprocessorContextActivationBlockNumber[preActivationContextId]
242+
) {
243+
uint256 activeContextId = getActiveCoprocessorContextId();
244+
245+
// Define the deactivation block number for the current active coprocessor context
246+
uint256 deactivatedBlockNumber = block.number + $.coprocessorContextSuspendedBlockPeriod[activeContextId];
247+
$.coprocessorContextDeactivatedBlockNumber[activeContextId] = deactivatedBlockNumber;
248+
249+
// Set the current active coprocessor context to the suspended state
250+
ContextLifecycle.setSuspended($.coprocessorContextLifecycle, activeContextId);
251+
emit SuspendCoprocessorContext(activeContextId, deactivatedBlockNumber);
252+
253+
// Set the new active coprocessor context
254+
ContextLifecycle.setActive($.coprocessorContextLifecycle, preActivationContextId);
255+
emit ActivateCoprocessorContext(preActivationContextId);
256256
}
257257

258-
// If there is a suspended coprocessor context, then check if it is time to deactivate it
258+
// Check if there is a suspended coprocessor context and if it is time to deactivate it
259259
uint256 suspendedContextId = _getSuspendedCoprocessorContextId();
260-
if (suspendedContextId != 0) {
261-
if (block.number >= $.coprocessorContextDeactivatedBlockNumber[suspendedContextId]) {
262-
ContextLifecycle.setDeactivated($.coprocessorContextLifecycle, suspendedContextId);
263-
emit DeactivateCoprocessorContext(suspendedContextId);
264-
}
260+
if (suspendedContextId != 0 && block.number >= $.coprocessorContextDeactivatedBlockNumber[suspendedContextId]) {
261+
ContextLifecycle.setDeactivated($.coprocessorContextLifecycle, suspendedContextId);
262+
emit DeactivateCoprocessorContext(suspendedContextId);
265263
}
266264
}
267265

gateway-contracts/rust_bindings/src/coprocessorcontexts.rs

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)