fix(test-suite): isolate local builds with :fhevm-local image tags

Prevent docker compose build from overwriting registry images when
--override builds locally. Local builds now use :fhevm-local tags,
keeping real registry images untouched. Also deduplicates services
sharing the same image tag (fixes buildx "already exists" error) and
skips compat CLI args for locally-built coprocessor services.

Author: Eikix

test-suite/fhevm/src/artifacts.ts

@@ -63,9 +63,29 @@ const ensureWritableDir = async (dir: string) => {
   await fs.chmod(dir, 0o777);
 };
 
+const LOCAL_BUILD_TAG = "fhevm-local";
+
 const loadComposeDoc = async (component: string) =>
   YAML.parse(await fs.readFile(path.join(TEMPLATE_COMPOSE_DIR, `${component}-docker-compose.yml`), "utf8")) as ComposeDoc;
 
+const overriddenServicesForComponent = (state: State, component: string) =>
+  new Set(
+    state.overrides.flatMap((o) =>
+      GROUP_BUILD_COMPONENTS[o.group].includes(component) ? GROUP_BUILD_SERVICES[o.group] : [],
+    ),
+  );
+
+const retagLocal = (image: unknown) =>
+  typeof image === "string" ? image.replace(/:([^:]+)$/, `:${LOCAL_BUILD_TAG}`) : image;
+
+const applyBuildPolicy = (service: Record<string, unknown>, isOverridden: boolean) => {
+  if (isOverridden) {
+    service.image = retagLocal(service.image);
+  } else {
+    delete service.build;
+  }
+};
+
 const appendVolume = (service: Record<string, unknown>, value: string) => {
   const volumes = Array.isArray(service.volumes) ? [...service.volumes] : [];
   if (!volumes.includes(value)) {
@@ -184,12 +204,17 @@ const applyInstanceAdjustments = (
 const buildCoprocessorOverride = async (state: State) => {
   const doc = rewriteComposePaths(await loadComposeDoc("coprocessor"));
   const next = structuredClone(doc);
+  const overridden = overriddenServicesForComponent(state, "coprocessor");
   const services: Record<string, Record<string, unknown>> = {};
   const baseOverride = state.topology.instances["coprocessor-0"];
   const baseEnv = await readEnvFile(envPath("coprocessor"));
   const compat = compatPolicyForState(state);
+  // Skip compat args for overridden services — local builds use HEAD code, not the resolved version.
+  const compatArgs = overridden.size ? {} : compat.coprocessorArgs;
   for (const [name, service] of Object.entries(doc.services)) {
-    services[name] = applyInstanceAdjustments(service, envPath("coprocessor"), baseEnv, baseOverride, compat.coprocessorArgs);
+    const adjusted = applyInstanceAdjustments(service, envPath("coprocessor"), baseEnv, baseOverride, compatArgs);
+    applyBuildPolicy(adjusted, overridden.has(name));
+    services[name] = adjusted;
   }
   for (let index = 1; index < state.topology.count; index += 1) {
     const prefix = `coprocessor${index}-`;
@@ -202,9 +227,10 @@ const buildCoprocessorOverride = async (state: State) => {
         envPath(`coprocessor.${index}`),
         instanceEnv,
         override,
-        compat.coprocessorArgs,
+        compatArgs,
       );
       cloned.container_name = prefix + suffix;
+      applyBuildPolicy(cloned, overridden.has(name));
       if (cloned.depends_on && typeof cloned.depends_on === "object") {
         cloned.depends_on = Object.fromEntries(
           Object.entries(cloned.depends_on as Record<string, unknown>).map(([dep, value]) => [
@@ -225,9 +251,11 @@ const buildComposeOverride = async (component: string, state: State) => {
     return buildCoprocessorOverride(state);
   }
   const doc = rewriteComposePaths(structuredClone(await loadComposeDoc(component)));
+  const overridden = overriddenServicesForComponent(state, component);
   const envVars = await readEnvFile(envPath(component));
   for (const [name, service] of Object.entries(doc.services)) {
     Object.assign(service, interpolateComposeValue(service, envVars));
+    applyBuildPolicy(service, overridden.has(name));
     if (component === "gateway-sc") {
       if (name === "gateway-sc-add-network") {
         service.command = ["npx hardhat task:addHostChainsToGatewayConfig --use-internal-proxy-address true"];
@@ -456,8 +484,22 @@ const maybeBuild = async (
       if (!services.length) {
         continue;
       }
+      // Deduplicate services by image tag — buildx fails when two services
+      // produce the same output tag in a single `docker compose build`.
+      const seen = new Set<string>();
+      const deduped = services.filter((s) => {
+        const img = doc.services[s]?.image;
+        if (typeof img !== "string" || seen.has(img)) {
+          return false;
+        }
+        seen.add(img);
+        return true;
+      });
       log(`[build] ${override.group} (${component})`);
-      await deps.liveRunner([...dockerArgs(component), "build", ...services], { env: await composeEnv(state) });
+      for (const ref of await imageRefsForServices(component, deduped)) {
+        await deps.runner(["docker", "image", "rm", "-f", ref], { allowFailure: true });
+      }
+      await deps.liveRunner([...dockerArgs(component), "build", ...deduped], { env: await composeEnv(state) });
       await rememberBuiltImages(state, component, override.group, services, deps, saveState);
     }
   }