feat(gateway-contracts): add function to update operators (#1176)

Author: melanciani

.github/workflows/gateway-contracts-upgrade-tests.yml

@@ -45,7 +45,7 @@ jobs:
         with:
           # This version should be updated whenever we release new contract versions or
           # touch a contract upgrade path.
-          ref: v0.9.1
+          ref: v0.9.3
           path: previous-fhevm
           persist-credentials: 'false'
 

gateway-contracts/contracts/GatewayConfig.sol

@@ -36,11 +36,39 @@ interface IGatewayConfig {
     );
 
     /**
-     * @notice Emitted when the GatewayConfig is re-initialized from V2.
+     * @notice Emitted when the GatewayConfig is re-initialized from V3.
+     * @param newKmsNodes The new KMS nodes.
+     */
+    event ReinitializeGatewayConfigV3(KmsNode[] newKmsNodes);
+
+    /**
+     * @notice Emitted when the KMS nodes have been updated.
+     * @param newKmsNodes The new KMS nodes.
+     * @param newMpcThreshold The new MPC threshold.
+     * @param newPublicDecryptionThreshold The new public decryption threshold.
+     * @param newUserDecryptionThreshold The new user decryption threshold.
+     * @param newKmsGenThreshold The new key and CRS generation threshold.
+     */
+    event UpdateKmsNodes(
+        KmsNode[] newKmsNodes,
+        uint256 newMpcThreshold,
+        uint256 newPublicDecryptionThreshold,
+        uint256 newUserDecryptionThreshold,
+        uint256 newKmsGenThreshold
+    );
+
+    /**
+     * @notice Emitted when the coprocessors have been updated.
      * @param newCoprocessors The new coprocessors.
-     * @param coprocessorThreshold The new coprocessor threshold.
+     * @param newCoprocessorThreshold The new coprocessor threshold.
+     */
+    event UpdateCoprocessors(Coprocessor[] newCoprocessors, uint256 newCoprocessorThreshold);
+
+    /**
+     * @notice Emitted when the custodians have been updated.
+     * @param newCustodians The new custodians.
      */
-    event ReinitializeGatewayConfigV2(Coprocessor[] newCoprocessors, uint256 coprocessorThreshold);
+    event UpdateCustodians(Custodian[] newCustodians);
 
     /**
      * @notice Emitted when the MPC threshold has been updated.
@@ -182,11 +210,38 @@ interface IGatewayConfig {
     error ChainIdNotUint64(uint256 chainId);
 
     /**
-     * @notice Add a new host chain metadata to the GatewayConfig contract.
-     * @dev The associated chain ID must be non-zero and representable by a uint64.
-     * @param hostChain The new host chain metadata to include.
+     * @notice Update the list of KMS nodes and their thresholds.
+     * @dev ⚠️ This function should be used with caution as it can lead to unexpected behavior in
+     * some requests and the contracts should first be paused. It will be deprecated in the future.
+     * @param newKmsNodes The new KMS nodes.
+     * @param newMpcThreshold The new MPC threshold.
+     * @param newPublicDecryptionThreshold The new public decryption threshold.
+     * @param newUserDecryptionThreshold The new user decryption threshold.
+     * @param newKmsGenThreshold The new key and CRS generation threshold.
      */
-    function addHostChain(HostChain calldata hostChain) external;
+    function updateKmsNodes(
+        KmsNode[] calldata newKmsNodes,
+        uint256 newMpcThreshold,
+        uint256 newPublicDecryptionThreshold,
+        uint256 newUserDecryptionThreshold,
+        uint256 newKmsGenThreshold
+    ) external;
+
+    /**
+     * @notice Update the list of coprocessors and their threshold.
+     * @dev ⚠️ This function should be used with caution as it can lead to unexpected behavior in
+     * some requests and the contracts should first be paused. It will be deprecated in the future.
+     * @param newCoprocessors The new coprocessors.
+     * @param newCoprocessorThreshold The new coprocessor threshold.
+     */
+    function updateCoprocessors(Coprocessor[] calldata newCoprocessors, uint256 newCoprocessorThreshold) external;
+
+    /**
+     * @notice Update the list of custodians.
+     * @dev ⚠️ This function should be used with caution. It will be deprecated in the future.
+     * @param newCustodians The new custodians.
+     */
+    function updateCustodians(Custodian[] calldata newCustodians) external;
 
     /**
      * @notice Update the MPC threshold.
@@ -223,6 +278,13 @@ interface IGatewayConfig {
      */
     function updateCoprocessorThreshold(uint256 newCoprocessorThreshold) external;
 
+    /**
+     * @notice Add a new host chain metadata to the GatewayConfig contract.
+     * @dev The associated chain ID must be non-zero and representable by a uint64.
+     * @param hostChain The new host chain metadata to include.
+     */
+    function addHostChain(HostChain calldata hostChain) external;
+
     /**
      * @notice Pause all pausable gateway contracts.
      */

gateway-contracts/contracts/interfaces/IGatewayConfig.sol

@@ -3,6 +3,14 @@ pragma solidity ^0.8.24;
 import "../shared/Structs.sol";
 
 contract GatewayConfigMock {
+    struct Thresholds {
+        uint256 mpcThreshold;
+        uint256 publicDecryptionThreshold;
+        uint256 userDecryptionThreshold;
+        uint256 kmsGenThreshold;
+        uint256 coprocessorThreshold;
+    }
+
     event InitializeGatewayConfig(
         ProtocolMetadata metadata,
         uint256 mpcThreshold,
@@ -11,7 +19,19 @@ contract GatewayConfigMock {
         Custodian[] custodians
     );
 
-    event ReinitializeGatewayConfigV2(Coprocessor[] newCoprocessors, uint256 coprocessorThreshold);
+    event ReinitializeGatewayConfigV3(KmsNode[] newKmsNodes);
+
+    event UpdateKmsNodes(
+        KmsNode[] newKmsNodes,
+        uint256 newMpcThreshold,
+        uint256 newPublicDecryptionThreshold,
+        uint256 newUserDecryptionThreshold,
+        uint256 newKmsGenThreshold
+    );
+
+    event UpdateCoprocessors(Coprocessor[] newCoprocessors, uint256 newCoprocessorThreshold);
+
+    event UpdateCustodians(Custodian[] newCustodians);
 
     event UpdateMpcThreshold(uint256 newMpcThreshold);
 
@@ -30,15 +50,11 @@ contract GatewayConfigMock {
     event UnpauseAllGatewayContracts();
 
     function initializeFromEmptyProxy(
-        ProtocolMetadata memory initialMetadata,
-        uint256 initialMpcThreshold,
-        uint256 initialPublicDecryptionThreshold,
-        uint256 initialUserDecryptionThreshold,
-        uint256 initialKmsGenThreshold,
-        uint256 initialCoprocessorThreshold,
-        KmsNode[] memory initialKmsNodes,
-        Coprocessor[] memory initialCoprocessors,
-        Custodian[] memory initialCustodians
+        ProtocolMetadata calldata initialMetadata,
+        Thresholds calldata initialThresholds,
+        KmsNode[] calldata initialKmsNodes,
+        Coprocessor[] calldata initialCoprocessors,
+        Custodian[] calldata initialCustodians
     ) public {
         ProtocolMetadata memory metadata;
         uint256 mpcThreshold;
@@ -49,8 +65,32 @@ contract GatewayConfigMock {
         emit InitializeGatewayConfig(metadata, mpcThreshold, kmsNodes, coprocessors, custodians);
     }
 
-    function reinitializeV2(Coprocessor[] memory newCoprocessors, uint256 coprocessorThreshold) public {
-        emit ReinitializeGatewayConfigV2(newCoprocessors, coprocessorThreshold);
+    function reinitializeV3(KmsNode[] calldata newKmsNodes) public {
+        emit ReinitializeGatewayConfigV3(newKmsNodes);
+    }
+
+    function updateKmsNodes(
+        KmsNode[] calldata newKmsNodes,
+        uint256 newMpcThreshold,
+        uint256 newPublicDecryptionThreshold,
+        uint256 newUserDecryptionThreshold,
+        uint256 newKmsGenThreshold
+    ) public {
+        emit UpdateKmsNodes(
+            newKmsNodes,
+            newMpcThreshold,
+            newPublicDecryptionThreshold,
+            newUserDecryptionThreshold,
+            newKmsGenThreshold
+        );
+    }
+
+    function updateCoprocessors(Coprocessor[] calldata newCoprocessors, uint256 newCoprocessorThreshold) external {
+        emit UpdateCoprocessors(newCoprocessors, newCoprocessorThreshold);
+    }
+
+    function updateCustodians(Custodian[] calldata newCustodians) external {
+        emit UpdateCustodians(newCustodians);
     }
 
     function updateMpcThreshold(uint256 newMpcThreshold) external {