Skip to content

Commit 8c859b3

Browse files
committed
refactor(coprocessor): remove high-cardinality IDs from child spans
Drop per-handle and per-ciphertext span attributes that caused cardinality explosion in spanmetrics. Operation-level identity is now carried by pattern_id hashes instead.
1 parent 779959f commit 8c859b3

17 files changed

+48
-403
lines changed

coprocessor/fhevm-engine/.sqlx/query-010fa361eaab3fcabb474adf8f2514f2fed77910cf3b29ffe9d73536425c9853.json

Lines changed: 0 additions & 53 deletions
This file was deleted.

coprocessor/fhevm-engine/.sqlx/query-4a7100e2b6599cb8ce75448cbe309aa64a26c670a394b3dafc89b944d4ae8cbc.json

Lines changed: 0 additions & 28 deletions
This file was deleted.

coprocessor/fhevm-engine/.sqlx/query-bbd25e5c5690ba1ce84d97a39c7a979b8c36ff03dafefe054b2884fb4cc8d13d.json renamed to coprocessor/fhevm-engine/.sqlx/query-5607dda24b648389b71fce084cffd17fcb37877d9a926cce37af567dc67da9c1.json

Lines changed: 3 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coprocessor/fhevm-engine/.sqlx/query-8907197e8a8331301874d45165cfd616f1c2bccd985dd6bb24269f53dff9e66b.json

Lines changed: 0 additions & 89 deletions
This file was deleted.

coprocessor/fhevm-engine/.sqlx/query-e5fa35861343ea78408c3794de51ab35e328ab37e9aa7e13c500165c3dd16eb6.json

Lines changed: 0 additions & 34 deletions
This file was deleted.

coprocessor/fhevm-engine/.sqlx/query-f5306e6d9d3bdbbd6b67d6155e0aedb48aed916aa901574784f14d3d24ebec69.json

Lines changed: 0 additions & 34 deletions
This file was deleted.

coprocessor/fhevm-engine/.sqlx/query-f9949810df2903d253c3a7d7b7d3f848eb61470cf865ea5c2185440cafe9ff13.json

Lines changed: 0 additions & 34 deletions
This file was deleted.

coprocessor/fhevm-engine/.sqlx/query-fb8986ef0add0975068fd2f4ee9edd02645ded4a717b96c7b2c164651a79ad07.json

Lines changed: 0 additions & 14 deletions
This file was deleted.

coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ impl Database {
399399
}
400400

401401
#[rustfmt::skip]
402-
#[tracing::instrument(name = "handle_tfhe_event", skip_all, fields(txn_id = tracing::field::Empty))]
402+
#[tracing::instrument(name = "handle_tfhe_event", skip_all, fields(transaction_hash = %log.transaction_hash.as_ref().map(|h| to_hex(h.as_ref())).unwrap_or_default()))]
403403
pub async fn insert_tfhe_event(
404404
&self,
405405
tx: &mut Transaction<'_>,
@@ -414,11 +414,6 @@ impl Database {
414414
let ty = |to_type: &ToType| vec![*to_type];
415415
let as_bytes = |x: &ClearConst| x.to_be_bytes_vec();
416416
let fhe_operation = event_to_op_int(event);
417-
telemetry::record_short_hex_if_some(
418-
&tracing::Span::current(),
419-
"txn_id",
420-
log.transaction_hash.as_ref(),
421-
);
422417
let insert_computation = |tx, result, dependencies, scalar_byte| {
423418
self.insert_computation(tx, result, dependencies, fhe_operation, scalar_byte, log)
424419
};
@@ -566,7 +561,7 @@ impl Database {
566561
}
567562

568563
/// Handles all types of ACL events
569-
#[tracing::instrument(skip_all, fields(txn_id = tracing::field::Empty))]
564+
#[tracing::instrument(skip_all, fields(transaction_hash = %transaction_hash.as_ref().map(|h| to_hex(h.as_ref())).unwrap_or_default()))]
570565
pub async fn handle_acl_event(
571566
&self,
572567
tx: &mut Transaction<'_>,
@@ -577,11 +572,6 @@ impl Database {
577572
block_number: u64,
578573
) -> Result<bool, SqlxError> {
579574
let data = &event.data;
580-
telemetry::record_short_hex_if_some(
581-
&tracing::Span::current(),
582-
"txn_id",
583-
transaction_hash.as_ref(),
584-
);
585575

586576
let transaction_hash = transaction_hash.map(|h| h.to_vec());
587577

0 commit comments

Comments
 (0)