fix(gateway-contracts): improve forge version checking with range support (#1748)

* fix(gateway-contracts): improve forge version checking with range support

Replace hardcoded list of allowed forge versions with flexible min/max
range check. This makes the script more maintainable and allows any
forge version between 1.3.1 and 1.5.1.

Changes:
- Add 'packaging' library import for version comparison
- Replace ALLOWED_FORGE_VERSIONS list with MIN_FORGE_VERSION and MAX_FORGE_VERSION
- Extract numeric version from forge version string using regex
- Use semantic version comparison instead of string matching

This allows the script to accept any forge version within the specified
range without requiring hardcoded version strings for each patch release.

* refactor(gateway-contracts): use tuple comparison for version checking

Remove external `packaging` dependency in favor of simple tuple
comparison for semver validation. This is cleaner and has zero
external dependencies while correctly handling version comparisons
like 1.10.0 > 1.9.0.

Changes:
- Remove `packaging` library import
- Define MIN/MAX_FORGE_VERSION as tuples instead of strings
- Add simple parse_semver() helper function
- Use direct tuple comparison for version range check

* refactor(gateway-contracts): accept all forge 1.x versions >= 1.3.1

Change version check to accept any forge version >= 1.3.1 and < 2.0.0.
This reduces maintenance burden as new forge releases won't require
updating the script, while still protecting against major version
breaking changes.

Author: enitrat

gateway-contracts/scripts/bindings_update.py

@@ -17,7 +17,13 @@
 GW_MOCKS_DIR = GW_CONTRACTS_DIR.joinpath("mocks")
 
 # To update forge to the latest version locally, run `foundryup`
-ALLOWED_FORGE_VERSIONS = ["1.3.1-v1.3.1", "1.3.1-stable", "1.3.2-stable"]
+MIN_FORGE_VERSION = (1, 3, 1)
+MAX_FORGE_VERSION = (2, 0, 0)  # Exclusive upper bound
+
+
+def parse_semver(version_str: str) -> tuple:
+    """Parses a semver string (e.g., '1.3.1') into a tuple of integers."""
+    return tuple(int(x) for x in version_str.split("."))
 
 
 def init_cli() -> ArgumentParser:
@@ -95,7 +101,7 @@ def _check_forge_installed():
             log_error("ERROR: forge is not installed.")
             sys.exit(ExitStatus.FORGE_NOT_INSTALLED.value)
 
-        forge_version = (
+        forge_version_str = (
             subprocess.run(
                 ["forge", "--version"],
                 capture_output=True,
@@ -104,11 +110,23 @@ def _check_forge_installed():
             .stdout.splitlines()[0]
             .lstrip("forge Version: ")
         )
-        if forge_version not in ALLOWED_FORGE_VERSIONS:
+
+        # Extract version number from format like "1.3.1-stable" or "1.3.1-v1.3.1"
+        version_match = re.match(r'^(\d+\.\d+\.\d+)', forge_version_str)
+        if not version_match:
+            log_error(
+                f"ERROR: Could not parse forge version '{forge_version_str}'."
+            )
+            sys.exit(ExitStatus.WRONG_FORGE_VERSION.value)
+
+        forge_version = parse_semver(version_match.group(1))
+
+        if not (MIN_FORGE_VERSION <= forge_version < MAX_FORGE_VERSION):
+            min_str = ".".join(map(str, MIN_FORGE_VERSION))
+            max_str = ".".join(map(str, MAX_FORGE_VERSION))
             log_error(
-                "ERROR: Required forge version to be one of these: "
-                f"`{ALLOWED_FORGE_VERSIONS}` but '{forge_version}' is "
-                "currently installed."
+                f"ERROR: Forge version must be >= {min_str} and < {max_str}, "
+                f"but '{forge_version_str}' is currently installed."
             )
             sys.exit(ExitStatus.WRONG_FORGE_VERSION.value)