chore(protocol-contracts): revert if diff is null

Author: melanciani

protocol-contracts/staking/contracts/OperatorStaking.sol

@@ -76,7 +76,7 @@ contract OperatorStaking is ERC1363Upgradeable, ReentrancyGuardTransient, UUPSUp
     error InvalidController();
 
     /// @dev Thrown when liquid asset balance is insufficient to cover pending redemptions in {stakeExcess}.
-    error InsufficientLiquidBalance(uint256 liquidBalance, uint256 assetsPendingRedemption);
+    error NoExcessBalance(uint256 liquidBalance, uint256 assetsPendingRedemption);
 
     modifier onlyOwner() {
         require(msg.sender == owner(), CallerNotProtocolStakingOwner(msg.sender));
@@ -242,17 +242,15 @@ contract OperatorStaking is ERC1363Upgradeable, ReentrancyGuardTransient, UUPSUp
      *
      * NOTE: Excess tokens will be in the `OperatorStaking` contract the operator is slashed
      * during a redemption flow or if donations are made to it. Anyone can call this function to
-     * restake those tokens.
+     * restake those tokens. This function will revert if the liquid balance is less than or equal
+     * to the amount of assets in pending redemption .
      */
     function stakeExcess() public virtual {
         ProtocolStaking protocolStaking_ = protocolStaking();
         protocolStaking_.release(address(this));
         uint256 liquidBalance = IERC20(asset()).balanceOf(address(this));
         uint256 assetsPendingRedemption = previewRedeem(totalSharesInRedemption());
-        require(
-            liquidBalance >= assetsPendingRedemption,
-            InsufficientLiquidBalance(liquidBalance, assetsPendingRedemption)
-        );
+        require(liquidBalance > assetsPendingRedemption, NoExcessBalance(liquidBalance, assetsPendingRedemption));
         uint256 amountToRestake = liquidBalance - assetsPendingRedemption;
         protocolStaking_.stake(amountToRestake);
     }

protocol-contracts/staking/test/OperatorStaking.test.ts

@@ -415,19 +415,19 @@ describe('OperatorStaking', function () {
         .withArgs(this.mock, this.protocolStaking, restakeAmount);
     });
 
-    it('should revert with InsufficientLiquidBalance when liquid balance is less than pending redemptions', async function () {
+    it('should revert with NoExcessBalance when liquid balance is less than pending redemptions', async function () {
       // Deposit and request redemption
       await this.mock.connect(this.delegator1).deposit(ethers.parseEther('10'), this.delegator1);
       await this.mock.connect(this.delegator1).requestRedeem(ethers.parseEther('5'), this.delegator1, this.delegator1);
 
-      // Slash staked balance to reduce available funds (slash remaining 5 ETH staked)
+      // Slash staked balance to reduce available funds (slash 3 assets)
       await this.protocolStaking.slashWithdrawal(this.mock, ethers.parseEther('3'));
 
       await timeIncreaseNoMine(60);
 
       // Now liquid balance (after release) will be less than assets pending redemption
       // since slashing reduced the staked balance but pending redemption still expects original value
-      await expect(this.mock.stakeExcess()).to.be.revertedWithCustomError(this.mock, 'InsufficientLiquidBalance');
+      await expect(this.mock.stakeExcess()).to.be.revertedWithCustomError(this.mock, 'NoExcessBalance');
     });
   });