Skip to content

perf: avoid unnecessary clones in query_ciphertexts#1875

Merged
mergify[bot] merged 1 commit intozama-ai:mainfrom
raushan728:perf/reduce-allocations-worker
Apr 10, 2026
Merged

perf: avoid unnecessary clones in query_ciphertexts#1875
mergify[bot] merged 1 commit intozama-ai:mainfrom
raushan728:perf/reduce-allocations-worker

Conversation

@raushan728
Copy link
Copy Markdown
Contributor

@raushan728 raushan728 commented Feb 2, 2026

Optimized memory usage by moving row ownership directly into ciphertext_map instead of cloning. This eliminates unnecessary double-allocations of ciphertext buffers

@raushan728 raushan728 requested a review from a team as a code owner February 2, 2026 10:34
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Feb 2, 2026

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @raushan728 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

1 similar comment
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Feb 2, 2026

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @raushan728 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@raushan728
Copy link
Copy Markdown
Contributor Author

raushan728 commented Feb 3, 2026

I have signed the CLA via DocuSign yesterday, but the check is still showing as failed. Could you please trigger a manual refresh or check if everything is correct on your end? Also, looking forward to the CI workflow approval. Thanks

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Feb 3, 2026

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @raushan728 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@enitrat
Copy link
Copy Markdown
Contributor

enitrat commented Feb 3, 2026

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Feb 3, 2026

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @raushan728 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Feb 3, 2026

The cla-bot has been summoned, and re-checked this pull request!

@raushan728
Copy link
Copy Markdown
Contributor Author

raushan728 commented Feb 3, 2026

hi @enitrat 1 have signed the CLA with the same email as my GitHub account and the status is 'Completed' on DocuSign (see attached screenshot). However, the @cla-bot is still failing to recognize it

Could you please manually verify my status so we can move forward
image

@raushan728
Copy link
Copy Markdown
Contributor Author

raushan728 commented Feb 4, 2026

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Feb 4, 2026

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @raushan728 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Feb 4, 2026

The cla-bot has been summoned, and re-checked this pull request!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

This PR is unverified and has been open for 2 days, it will now be closed. If you want to contribute please sign the CLA as indicated by the bot.

@github-actions github-actions Bot added the Stale label Feb 5, 2026
@github-actions github-actions Bot closed this Feb 5, 2026
@raushan728
Copy link
Copy Markdown
Contributor Author

raushan728 commented Feb 5, 2026

Hi @0xalexbel (Alexandre Quint) and @zama-ai/fhe-team,
My PR #1875 was automatically closed by the bot despite me signing the CLA via DocuSign 2 days ago. I have already attached the 'Completed' screenshot above.
Could you please reopen this manually? It's frustrating to see a valid performance contribution get closed due to a bot glitch. My GitHub and DocuSign emails are identical.

@raushan728 raushan728 mentioned this pull request Feb 5, 2026
Closed
@aquint-zama
Copy link
Copy Markdown
Contributor

aquint-zama commented Mar 2, 2026

@cla-bot check

@aquint-zama aquint-zama reopened this Mar 2, 2026
@cla-bot cla-bot Bot added the cla-signed label Mar 2, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 2, 2026

The cla-bot has been summoned, and re-checked this pull request!

@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 2, 2026 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 828259a.

❌ Job Failures

Pipeline Job Health on main Retries 🔍 CI Insights 📄 Logs
coprocessor-cargo-test coprocessor-cargo-test/cargo-tests (bpr) Unknown 0 View View

@Eikix
Copy link
Copy Markdown
Contributor

Eikix commented Mar 23, 2026

Closing as stale

@Eikix Eikix closed this Mar 23, 2026
@rudy-6-4 rudy-6-4 reopened this Apr 10, 2026
@rudy-6-4
Copy link
Copy Markdown
Contributor

rudy-6-4 commented Apr 10, 2026

Hi @raushan728
Can you format (and rebase) your PR using cargo fmt ?
Thank you

@raushan728
Copy link
Copy Markdown
Contributor Author

raushan728 commented Apr 10, 2026

Hi @raushan728
Can you format (and rebase) your PR using cargo fmt ?
Thank you

Sure, I'll push it

@raushan728 raushan728 force-pushed the perf/reduce-allocations-worker branch from 828259a to ab515a6 Compare April 10, 2026 14:25
@raushan728
Copy link
Copy Markdown
Contributor Author

raushan728 commented Apr 10, 2026

@rudy-6-4 Done

@rudy-6-4
Copy link
Copy Markdown
Contributor

rudy-6-4 commented Apr 10, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 10, 2026 •
edited
Loading

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule main]:
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • base = main
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=do-not-merge
      • any of [🛡 GitHub branch protection]:
        • check-success = common-pull-request/lint (bpr)
        • check-neutral = common-pull-request/lint (bpr)
        • check-skipped = common-pull-request/lint (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-success = coprocessor-cargo-test/cargo-tests (bpr)
        • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
        • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
        • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
        • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
        • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
        • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
      • any of [🛡 GitHub branch protection]:
        • check-skipped = kms-connector-tests/test-connector (bpr)
        • check-neutral = kms-connector-tests/test-connector (bpr)
        • check-success = kms-connector-tests/test-connector (bpr)

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 10, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 2 hours 16 minutes 14 seconds in the queue, including 1 hour 15 minutes running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • check-success = run-e2e-tests / fhevm-e2e-test
  • any of [🛡 GitHub branch protection]:
    • check-success = common-pull-request/lint (bpr)
    • check-neutral = common-pull-request/lint (bpr)
    • check-skipped = common-pull-request/lint (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = coprocessor-cargo-test/cargo-tests (bpr)
    • check-neutral = coprocessor-cargo-test/cargo-tests (bpr)
    • check-skipped = coprocessor-cargo-test/cargo-tests (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-success = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-neutral = coprocessor-dependency-analysis/dependencies-check (bpr)
    • check-skipped = coprocessor-dependency-analysis/dependencies-check (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-neutral = gateway-contracts-deployment-tests/sc-deploy (bpr)
    • check-success = gateway-contracts-deployment-tests/sc-deploy (bpr)
  • any of [🛡 GitHub branch protection]:
    • check-skipped = kms-connector-tests/test-connector (bpr)
    • check-neutral = kms-connector-tests/test-connector (bpr)
    • check-success = kms-connector-tests/test-connector (bpr)

@mergify mergify Bot removed the merge-queued label Apr 10, 2026
mergify Bot added a commit that referenced this pull request Apr 10, 2026
@mergify
Merge of #1875
f6d9606
@mergify mergify Bot mentioned this pull request Apr 10, 2026
Closed
51 tasks
@mergify mergify Bot merged commit b6c8c2b into zama-ai:main Apr 10, 2026
83 checks passed
@mergify mergify Bot removed the queued label Apr 10, 2026
@raushan728 raushan728 deleted the perf/reduce-allocations-worker branch April 13, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rudy-6-4 rudy-6-4 rudy-6-4 approved these changes

Assignees

No one assigned

Labels

cla-signed Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raushan728 @enitrat @aquint-zama @Eikix @rudy-6-4