fix(gateway-contracts): overload isUserDecryptionReady with old signature#2137
Merged
mergify[bot] merged 1 commit intomainfrom Mar 20, 2026
Conversation
jatZama
previously approved these changes
Mar 19, 2026
zmalatrax
force-pushed
the
fix/simple-acl/gateway-is-user-decryption-ready-backward-compatibility
branch
2 times, most recently
from
9312a61 to
d5e486e
Compare
zmalatrax
changed the title
isUserDecryptionReady with old signature for backward compatibilityisUserDecryptionReady with old signature
zmalatrax
force-pushed
the
fix/simple-acl/gateway-is-user-decryption-ready-backward-compatibility
branch
from
d5e486e to
a511ea8
Compare
Contributor
Author
|
@mergify queue |
Merge Queue Status
This pull request spent 1 hour 41 minutes 10 seconds in the queue, including 40 minutes 22 seconds running CI. Required conditions to merge
|
51 tasks
mergify
bot
deleted the
fix/simple-acl/gateway-is-user-decryption-ready-backward-compatibility
branch
isaacdecoded
pushed a commit
that referenced
this pull request
Mar 20, 2026
…nature (#2137) fix(gateway-contracts): overload isUserDecryptionReady with old signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For v0.12, with the removal of
MultichainACL.solwe decided to update the signature of the view functionisUserDecryptionReady, fromisUserDecryptionReady(address, (bytes32, address)[], bytes)toisUserDecryptionReady((bytes32, address)[], bytes). See #1904Though, it actually breaks the relayer
mainuntil the upgrade is done on testnet and mainnet ; as updating the rust bindingsfhevm_gateway_bindingswould remove theisUserDecryptionReady(address, (bytes32, address)[], bytes)selector currently deployed on testnet and mainnet.Proposed solution is to overload the
isUserDecryptionReadyview function with its old signature, with a deprecation notice (custom label as not supported by NatSpec), which would allow backward compatibility during the upgrade window.Then, once mainnet has been upgraded, the old signature overload can be removed in the next contract upgrade