chore: Extract execution to own crate (#440)

* Pull down anyhow_error_and_log utility function (temp)

* Add skeleton threshold-algebra crate

* Add threshold-algebra crate

* Use new threshold-algebra crate

* Use new threshold-algebra crate

* Fix feature-gated invocations of old location of algebra

* Clean up error-utils

* Cleanup features a bit

* Don't re-export sharing from execution

* Rename `gen` module to `ggen` to avoid clashing with Rust reserved keyword

* Do not re-export Role

* Extract threading utilities to own crate: `thread-handles`.

* Sort out imports

* Update Cargo.lock

* Extract hashing to own crate

* Cleanup TODOs

* Merge conflicts

* Don't build full debug info in the test profile.

* chore: clippy fixes

* fix clippy warnings

* chore: clippy and test fixes

* Fix wasm build (I hope)

* Remove TODO

* fix conditional imports

* chore: extract execution and handle fallout. Not there yet.

* chore: fix session-id

* Moar files

* Repo type checks!

* Include execution in core-client

* Hackfix networking tests

* Ignore temp more broadly

* Ignore temp everywhere

* Move ddec test configs to the right place

* Add TODO about mismatched DkgMode in integration test

* Rename `ggen` to `proto_gen`

* Remove "non-wasm" feature from `threshold-algebra`

* Remove `algebra/slow_tests` feature just use `all_extension_degrees`

* Remove TODO that I will not address here (or ever).

* Cleanup thread-handles.
Use anyhow_error_and_log consistently

* Sort out TODO

* `error-utils` doesn't need any features

* Remove stale TODO

* Merge main

* move threshold/experimental into new threshold-experimental crate

* Add Cargo.toml for new crate

* fix threshold-experimental

* Move core/threshold/experimental to own crate: threshold-experimental

* Move BGV test scripts to new crate

* Fix build command in shell scripts

* Remove  stale code

* Sort out the circular dependency for the `moby` binary and ExperimentalChoreoGrpcChoreography

* Sort out todos in session-id

* Resolve some TODOs in networking

* Crate description for execution

* Crate descr for thershold-types

* Crate descr for threshold-experimental

* Cleanup threshold-fhe's Cargo.toml

* Remove unused dependencies from threshold-networking

* Remove feature gated trait methods and plenty of other code that must  be feature gated as a consequence.

* Remove unused deps from threshold-hashing

* More cleanup of features and unused deps

* Remove unused feature

* Just use strum and remove strum_macros

* Docs for ProtocolDescription

* Clean up TODOs

* Clean up TODOs

* Remove unused `PARAMS_DIR`

* Clean up TODOs

* Cleanup more TODOs

* Add new `test-utils` crate

* Add test-utils mini-crate. Likely more stuff will move here over time.

* Fix last usage of test-utils

* Clean up trivial TODOs

* Move randomness_checks to threshold-algebra

* Fix an import

* More  cleanup

* More cleaup

* Fixed a few more todos

* Move Role and some opening types to  threshold-types

* Adjust imports

* Fix self-reference in execution that causes cargo deny to panic

* formatting

* Sort out wasm builds

* Appease clippy

* More test fixes

* fix docker port

* More feature threading

* Propagate features

* Fix CI, part 32783718: ensure no big ass keys get generated when they mustn't.

* Clean up TODOs

* Upgrade `rstest` and get rid of `async-std`.

* Upgrade rstest to latest for less async-std

* Specify the async runtime for rstests

* chore: resolve an outstanding TODO

* chore: resolve outdated TODO

* chore: put back the funny looking test

* chore: resolve TODO – we're keeping threshold-experimental in the workspace (for now...)

* chore: trust the default feature

* chore: put clippy allows on the specific points rather than whole module

* Restore commented-out types in benchmarks

* chore: cleaner  Cargo.toml

* chore: Restore spurious changes to backward-compatibility

* chore: cleanup and make consistent

* chore: move SessionId to threshold-types

* chore: wire up session_id module, fix imports

* chore: re-work the session_id tests suite to stop testing encryption/hashing

* chore: move the *logic* related to commitments to threshold-algebra, while keeping types in threshold-types

* chore: revert unrelated changes to sender_service

* chore: don't use aliases for execution and networking

* chore: Fix import

Author: dvdplm

.gitignore

@@ -1,7 +1,7 @@
 CLAUDE.md
 .claude/
 /target*
-/temp
+**/temp/*
 /keys
 /crs
 /test-material

Cargo.lock

@@ -5,10 +5,15 @@ members = [
     "bc2wrap",
     "core/grpc",
     "core/service",
+    "core/test-utils",
+    "core/thread-handles",
     "core/threshold",
     "core/threshold-algebra",
+    "core/threshold-execution",
+    "core/threshold-experimental",
     "core/threshold-hashing",
-    "core/thread-handles",
+    "core/threshold-networking",
+    "core/threshold-types",
     "core/error-utils",
     "core-client",
     "observability",
@@ -73,13 +78,18 @@ description = "Key Management System for the Zama Protocol."
 algebra = { package = "threshold-algebra", path = "./core/threshold-algebra", default-features = false }
 backward-compatibility = { path = "./backward-compatibility" }  # Internal backward compatibility testing
 bc2wrap = { path = "./bc2wrap" }  # Internal bincode wrapper custom implementation
+error-utils = { path = "./core/error-utils", default-features = false }
+threshold-execution = { path = "./core/threshold-execution", default-features = false }
+experimental = { package = "threshold-experimental", path = "./core/threshold-experimental", default-features = false }
 hashing = { package = "threshold-hashing", path = "./core/threshold-hashing", default-features = false }
 kms = { path = "./core/service", default-features = false }  # Core KMS service
 kms-core-client = { path = "./core-client" }  # Core KMS client library
 kms-grpc = { path = "./core/grpc", default-features = false }  # KMS gRPC interface
+threshold-networking = { path = "./core/threshold-networking", default-features = false }
 observability = { path = "./observability" }  # Internal observability module
+test-utils = { path = "./core/test-utils" }
 threshold-fhe = { path = "./core/threshold/", default-features = false }  # Threshold FHE implementation
-error-utils = { path = "./core/error-utils", default-features = false }
+threshold-types = { path = "./core/threshold-types" } # Types share across the KMS
 thread-handles = { path = "./core/thread-handles" }
 
 # External dependencies (alphabetically sorted)

Cargo.toml

@@ -59,6 +59,7 @@ attestation-doc-validation.workspace = true
 bc2wrap.workspace = true
 bytes.workspace = true
 clap = { workspace = true, features = ["derive"] }
+threshold-execution.workspace = true
 hashing.workspace = true
 hex.workspace = true
 k256.workspace = true

core-client/Cargo.toml

@@ -14,7 +14,7 @@ use kms_lib::util::key_setup::test_tools::load_material_from_pub_storage;
 use std::collections::HashMap;
 use std::path::Path;
 use tfhe::zk::CompactPkeCrs;
-use threshold_fhe::execution::zk::ceremony::max_num_bits_from_crs;
+use threshold_execution::zk::ceremony::max_num_bits_from_crs;
 use tokio::task::JoinSet;
 use tonic::transport::Channel;
 
@@ -350,7 +350,7 @@ mod tests {
     };
     use std::str::FromStr;
     use tfhe::zk::CompactPkeCrs;
-    use threshold_fhe::execution::zk::ceremony::max_num_bits_from_crs;
+    use threshold_execution::zk::ceremony::max_num_bits_from_crs;
 
     #[tokio::test]
     async fn test_eip712_sigs() {

core-client/src/crsgen.rs

@@ -103,6 +103,7 @@ impl DockerComposeCmd {
             | KMSMode::ThresholdCustodianTestParameter => {
                 &[50100, 50200, 50300, 50400, 50001, 50002, 50003, 50004]
             }
+            // Must match the port as defined in kms/docker-compose-core-centralized.yml
             KMSMode::Centralized | KMSMode::CentralizedCustodian => &[50051],
         }
     }

core-client/tests-utils/src/lib.rs

@@ -26,6 +26,7 @@ hex.workspace = true
 prost.workspace = true
 rand = { workspace = true, features = ["std", "std_rng"] }
 serde = { workspace = true, features = ["derive", "rc"] }
+threshold-types.workspace = true
 strum.workspace = true
 strum_macros.workspace = true
 thiserror.workspace = true
@@ -38,9 +39,6 @@ tfhe = { workspace = true, features = [
     "experimental-force_fft_algo_dif4",
 ] }
 tfhe-versionable.workspace = true
-threshold-fhe = { workspace = true, default-features = false, features = [
-    "extension_degree_4",
-] }
 tracing = { workspace = true, features = ["log"] }
 wasm-bindgen.workspace = true