chore: remove error increment counted twice

Author: titouantanguy

core/service/src/engine/threshold/service/crs_generator.rs

@@ -12,8 +12,8 @@ use kms_grpc::{
 use observability::{
     metrics,
     metrics_names::{
-        ERR_CANCELLED, ERR_CRS_GEN_FAILED, ERR_INVALID_REQUEST, OP_CRS_GEN_REQUEST,
-        OP_INSECURE_CRS_GEN_REQUEST, TAG_PARTY_ID,
+        ERR_CANCELLED, ERR_CRS_GEN_FAILED, OP_CRS_GEN_REQUEST, OP_INSECURE_CRS_GEN_REQUEST,
+        TAG_PARTY_ID,
     },
 };
 use threshold_fhe::{
@@ -185,9 +185,7 @@ impl<
             guarded_meta_store.insert(&req_id)?;
         }
 
-        let session_id = req_id.derive_session_id().inspect_err(|_| {
-            metrics::METRICS.increment_error_counter(op_tag, ERR_INVALID_REQUEST);
-        })?;
+        let session_id = req_id.derive_session_id()?;
         // CRS ceremony requires a sync network
         let session = self
             .session_preparer

core/service/src/engine/threshold/service/public_decryptor.rs

@@ -281,10 +281,6 @@ impl<
                     request_id = ?inner.request_id,
                     "Failed to validate decrypt request"
                 );
-                let _ = metrics::METRICS.increment_error_counter(
-                    OP_PUBLIC_DECRYPT_REQUEST,
-                    ERR_PUBLIC_DECRYPTION_FAILED,
-                );
             })?;
 
         // Do some checks before we start modifying the database

core/service/src/engine/threshold/service/user_decryptor.rs

@@ -442,8 +442,6 @@ impl<
                     "Failed to validate decrypt request {}",
                     format_user_request(&inner)
                 );
-                let _ = metrics::METRICS
-                    .increment_error_counter(OP_USER_DECRYPT_REQUEST, ERR_USER_DECRYPTION_FAILED);
             })?;
 
         timer.tags([(TAG_KEY_ID, key_id.as_str())]);