Skip to content

Commit a33c12d

Browse files
committed
chore(ci): fix zizmor findings in workflows
1 parent 522a612 commit a33c12d

File tree

70 files changed

+198
-102
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+198
-102
lines changed

.github/dependabot.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,5 @@ updates:
77
# Check for updates to GitHub Actions every sunday
88
interval: "weekly"
99
day: "sunday"
10+
cooldown:
11+
default-days: 7

.github/workflows/approve_label.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@ on:
99

1010
permissions: {}
1111

12+
# zizmor: ignore[concurrency-limits] this workflow needs to react to any event in a pull-request
13+
1214
jobs:
1315
trigger-tests:
1416
name: approve_label/trigger-tests
1517
runs-on: ubuntu-latest
1618
permissions:
17-
pull-requests: write
19+
pull-requests: write # Needed to apply or remove label
1820
steps:
1921
- name: Get current labels
2022
uses: snnaplab/get-labels-action@f426df40304808ace3b5282d4f036515f7609576

.github/workflows/aws_tfhe_backward_compat_tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ on:
2929
permissions:
3030
contents: read
3131

32+
# zizmor: ignore[concurrency-limits] concurrency is managed after instance setup to ensure safe provisioning
33+
3234
jobs:
3335
setup-instance:
3436
name: aws_tfhe_backward_compat_tests/setup-instance
@@ -58,10 +60,10 @@ jobs:
5860
backward-compat-tests:
5961
name: aws_tfhe_backward_compat_tests/backward-compat-tests (bpr)
6062
needs: [ setup-instance ]
63+
runs-on: ${{ needs.setup-instance.outputs.runner-name }}
6164
concurrency:
6265
group: ${{ github.workflow_ref }}${{ github.ref == 'refs/heads/main' && github.sha || '' }}
6366
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
64-
runs-on: ${{ needs.setup-instance.outputs.runner-name }}
6567
steps:
6668
- name: Checkout tfhe-rs
6769
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8

.github/workflows/aws_tfhe_fast_tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,14 @@ on:
2727
permissions:
2828
contents: read
2929

30+
# zizmor: ignore[concurrency-limits] concurrency is managed after instance setup to ensure safe provisioning
31+
3032
jobs:
3133
should-run:
3234
name: aws_tfhe_fast_tests/should-run
3335
runs-on: ubuntu-latest
3436
permissions:
35-
pull-requests: read
37+
pull-requests: read # Needed to check for file change
3638
outputs:
3739
csprng_test: ${{ env.IS_PULL_REQUEST == 'false' || steps.changed-files.outputs.csprng_any_changed }}
3840
zk_pok_test: ${{ env.IS_PULL_REQUEST == 'false' || steps.changed-files.outputs.zk_pok_any_changed }}

.github/workflows/aws_tfhe_integer_tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ on:
3333
permissions:
3434
contents: read
3535

36+
# zizmor: ignore[concurrency-limits] concurrency is managed after instance setup to ensure safe provisioning
37+
3638
jobs:
3739
should-run:
3840
name: aws_tfhe_integer_tests/should-run
@@ -42,7 +44,7 @@ jobs:
4244
github.event_name == 'workflow_dispatch'
4345
runs-on: ubuntu-latest
4446
permissions:
45-
pull-requests: read
47+
pull-requests: read # Needed to check for file change
4648
outputs:
4749
integer_test: ${{ github.event_name == 'workflow_dispatch' ||
4850
steps.changed-files.outputs.integer_any_changed }}

.github/workflows/aws_tfhe_noise_checks.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ on:
2323
permissions:
2424
contents: read
2525

26+
# zizmor: ignore[concurrency-limits] only Zama organization members can trigger this workflow
27+
2628
jobs:
2729
setup-instance:
2830
name: aws_tfhe_noise_checks/setup-instance

.github/workflows/aws_tfhe_signed_integer_tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ on:
3333
permissions:
3434
contents: read
3535

36+
# zizmor: ignore[concurrency-limits] concurrency is managed after instance setup to ensure safe provisioning
37+
3638
jobs:
3739
should-run:
3840
name: aws_tfhe_signed_integer_tests/should-run
@@ -43,7 +45,7 @@ jobs:
4345
github.event_name == 'workflow_dispatch'
4446
runs-on: ubuntu-latest
4547
permissions:
46-
pull-requests: read
48+
pull-requests: read # Needed to check for file change
4749
outputs:
4850
integer_test: ${{ github.event_name == 'workflow_dispatch' ||
4951
steps.changed-files.outputs.integer_any_changed }}

.github/workflows/aws_tfhe_tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,16 @@ on:
3030
permissions:
3131
contents: read
3232

33+
# zizmor: ignore[concurrency-limits] concurrency is managed after instance setup to ensure safe provisioning
34+
3335
jobs:
3436
should-run:
3537
name: aws_tfhe_tests/should-run
3638
runs-on: ubuntu-latest
3739
if: github.event_name != 'schedule' ||
3840
(github.event_name == 'schedule' && github.repository == 'zama-ai/tfhe-rs')
3941
permissions:
40-
pull-requests: read
42+
pull-requests: read # Needed to check for file change
4143
outputs:
4244
csprng_test: ${{ env.IS_PULL_REQUEST == 'false' || steps.changed-files.outputs.csprng_any_changed }}
4345
zk_pok_test: ${{ env.IS_PULL_REQUEST == 'false' || steps.changed-files.outputs.zk_pok_any_changed }}

.github/workflows/aws_tfhe_wasm_tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ on:
2626
permissions:
2727
contents: read
2828

29+
# zizmor: ignore[concurrency-limits] concurrency is managed after instance setup to ensure safe provisioning
30+
2931
jobs:
3032
setup-instance:
3133
name: aws_tfhe_wasm_tests/setup-instance
@@ -57,7 +59,7 @@ jobs:
5759
name: aws_tfhe_wasm_tests/wasm-tests
5860
needs: setup-instance
5961
concurrency:
60-
group: ${{ github.workflow_ref }}
62+
group: ${{ github.workflow_ref }}_${{github.event_name}}
6163
cancel-in-progress: true
6264
runs-on: ${{ needs.setup-instance.outputs.runner-name }}
6365
steps:

.github/workflows/benchmark_cpu.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ on:
6060

6161
permissions: {}
6262

63+
# zizmor: ignore[concurrency-limits] only Zama organization members can trigger this workflow
64+
6365
jobs:
6466
run-benchmarks:
6567
name: benchmark_cpu/run-benchmarks

0 commit comments

Comments
 (0)