chore(bench): revert print bench id #3006
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soonum
approved these changes
Nov 14, 2025
Contributor
soonum
left a comment
soonum
left a comment
There was a problem hiding this comment.
Sorry for the noise in the output.
IceTDrinker
reviewed
Nov 14, 2025
Member
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
thanks, hopefully we'll find a way to get this to work the way we want
Reviewable status: 0 of 23 files reviewed, all discussions resolved
This reverts commit ef07963.
mayeul-zama
force-pushed
the
mz/revert_print_bench
branch
from
4ac9bcc to
7672c6d
Compare
IceTDrinker
approved these changes
Nov 14, 2025
Member
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
Thanks, not sure why you needed to rebase
Contributor
|
I merged a change in the AES GPU bench in the meanwhile where I had to add print bench_id to solve conflicts with main 😅 |
Member
no problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is