Fixed lint warnings: unicorn/no-for-loop

Signed-off-by: Vitika9 <[email protected]>

Author: VitikaSoni

package.json

@@ -78,7 +78,7 @@
       ],
       "no-unused-vars": "error",
       "prefer-destructuring": "warn",
-      "unicorn/no-for-loop": "warn",
+      "unicorn/no-for-loop": "error",
       "unicorn/prefer-includes": "warn",
       "unicorn/prefer-string-slice": "warn",
       "unicorn/filename-case": "warn",

src/main/zapHomeFiles/hud/display.js

@@ -736,10 +736,9 @@ Vue.component('site-tree-node', {
 			channel.port1.addEventListener('message', event => {
 				// Remove the ..loading.. child
 				Vue.set(treeNode.model, 'children', []);
-				for (let i = 0; i < event.data.childNodes.length; i++) {
-					const child = event.data.childNodes[i];
+				event.data.childNodes.forEach(child => {
 					treeNode.addChild(child.name, child.method, child.isLeaf, child.hrefId);
-				}
+				});
 			});
 
 			navigator.serviceWorker.controller.postMessage({

src/main/zapHomeFiles/hud/tools/break.js

@@ -140,11 +140,11 @@ const Break = (function () {
 				let r = false;
 
 				if (isFirefox) {
-					for (let i = 0; i < clients.length; i++) {
-						if (clients[i].visibilityState === 'visible') {
+					clients.forEach(client => {
+						if (client.visibilityState === 'visible') {
 							r = true;
 						}
-					}
+					});
 				} else if (clients.length > 0) {
 					r = true;
 				}
@@ -202,11 +202,11 @@ const Break = (function () {
 				let r = false;
 
 				if (isFirefox) {
-					for (let i = 0; i < clients.length; i++) {
-						if (clients[i].visibilityState === 'visible') {
+					clients.forEach(client => {
+						if (client.visibilityState === 'visible') {
 							r = true;
 						}
-					}
+					});
 				} else if (clients.length > 0) {
 					r = true;
 				}

src/main/zapHomeFiles/hud/tools/commonAlerts.js

@@ -145,8 +145,8 @@ const CommonAlerts = (function () {
 								for (const alertName in pageAlerts[alertRisk]) {
 									if (Object.prototype.hasOwnProperty.call(pageAlerts[alertRisk], alertName)) {
 										const reportedParameters = new Set();
-										for (let i = 0; i < pageAlerts[alertRisk][alertName].length; i++) {
-											const alert = pageAlerts[alertRisk][alertName][i];
+
+										pageAlerts[alertRisk][alertName].forEach(alert => {
 											if (alert.param.length > 0 && !reportedParameters.has(alert.param)) {
 												reportedParameters.add(alert.param);
 												utils.messageFrame(event.detail.tabId, 'management', {
@@ -156,7 +156,7 @@ const CommonAlerts = (function () {
 													risk: alert.risk,
 													param: alert.param});
 											}
-										}
+										});
 									}
 								}
 							}

src/main/zapHomeFiles/hud/tools/utils/alertUtils.js

@@ -40,14 +40,14 @@ const alertUtils = (function () {
 
 	function flattenAlerts(alerts) {
 		const json = {};
-		for (let i = 0; i < alerts.length; i++) {
-			const alert = alerts[i];
+
+		alerts.forEach(alert => {
 			for (const key in alert) {
 				if (Object.prototype.hasOwnProperty.call(alert, key)) {
 					json[key] = alert[key];
 				}
 			}
-		}
+		});
 
 		return json;
 	}

src/main/zapHomeFiles/hud/utils.js

@@ -195,8 +195,8 @@ const utils = (function () {
 	function setDefaultTools(leftTools, rightTools) {
 		const promises = [];
 
-		for (let i = 0; i < leftTools.length; i++) {
-			loadTool(leftTools[i])
+		leftTools.forEach((leftTool, i) => {
+			loadTool(leftTool)
 				.then(tool => {
 					if (!tool) {
 						log(LOG_ERROR, 'utils.setDefaultTools', 'Failed to load tool.', tool.name);
@@ -210,10 +210,10 @@ const utils = (function () {
 					return writeTool(tool);
 				})
 				.catch(errorHandler);
-		}
+		});
 
-		for (let i = 0; i < rightTools.length; i++) {
-			loadTool(rightTools[i])
+		rightTools.forEach((rightTool, i) => {
+			loadTool(rightTool)
 				.then(tool => {
 					if (!tool) {
 						log(LOG_ERROR, 'utils.setDefaultTools', 'Failed to load tool.', tool.name);
@@ -227,7 +227,7 @@ const utils = (function () {
 					return writeTool(tool);
 				})
 				.catch(errorHandler);
-		}
+		});
 
 		return Promise.all(promises);
 	}
@@ -430,8 +430,7 @@ const utils = (function () {
 	function messageFrame(tabId, frameId, message) {
 		return clients.matchAll({includeUncontrolled: true})
 			.then(clients => {
-				for (let i = 0; i < clients.length; i++) {
-					const client = clients[i];
+				clients.forEach(client => {
 					const parameters = new URL(client.url).searchParams;
 
 					const tid = parameters.get('tabId');
@@ -440,7 +439,7 @@ const utils = (function () {
 					if (tid === tabId && fid === frameId) {
 						return client;
 					}
-				}
+				});
 
 				throw new NoClientIdError('Could not find a ClientId for tabId: ' + tabId + ', frameId: ' + frameId);
 			})
@@ -469,16 +468,15 @@ const utils = (function () {
 			.then(clients => {
 				const frameClients = [];
 
-				for (let i = 0; i < clients.length; i++) {
-					const client = clients[i];
+				clients.forEach(client => {
 					const parameters = new URL(client.url).searchParams;
 
 					const fid = parameters.get('frameId');
 
 					if (fid === frameId) {
 						frameClients.push(client);
 					}
-				}
+				});
 
 				if (frameClients.length === 0) {
 					log(LOG_DEBUG, 'utils.messageAllTabs', 'Could not find any clients for frameId: ' + frameId, message);
@@ -489,9 +487,7 @@ const utils = (function () {
 			})
 			.then(clients => {
 				return new Promise(((resolve, reject) => {
-					for (let i = 0; i < clients.length; i++) {
-						const client = clients[i];
-
+					clients.forEach(client => {
 						const channel = new MessageChannel();
 						channel.port1.start();
 						channel.port2.start();
@@ -505,7 +501,7 @@ const utils = (function () {
 						});
 
 						client.postMessage(message, [channel.port2]);
-					}
+					});
 				}));
 			})
 			.catch(errorHandler);
@@ -524,16 +520,15 @@ const utils = (function () {
 			.then(clients => {
 				const frameClients = [];
 
-				for (let i = 0; i < clients.length; i++) {
-					const client = clients[i];
+				clients.forEach(client => {
 					const parameters = new URL(client.url).searchParams;
 
 					const fid = parameters.get('frameId');
 
 					if (fid === frameId) {
 						frameClients.push(client);
 					}
-				}
+				});
 
 				return frameClients;
 			})