Fixed lint warnings: unicorn/prefer-includes

Signed-off-by: Vitika9 <[email protected]>

Author: VitikaSoni

package.json

@@ -79,7 +79,7 @@
       "no-unused-vars": "error",
       "prefer-destructuring": "error",
       "unicorn/no-for-loop": "error",
-      "unicorn/prefer-includes": "warn",
+      "unicorn/prefer-includes": "error",
       "unicorn/prefer-string-slice": "warn",
       "unicorn/filename-case": "warn",
       "unicorn/prefer-query-selector": "error"

src/main/zapHomeFiles/hud/drawer.js

@@ -56,7 +56,7 @@ Vue.component('history', {
 					return re.test(message.url);
 				}
 
-				return message.url.indexOf(self.filter) >= 0;
+				return message.url.includes(self.filter);
 			});
 		}
 	},
@@ -170,7 +170,7 @@ Vue.component('websockets', {
 					return re.test(message.messageSummary);
 				}
 
-				return message.messageSummary.indexOf(self.filter) >= 0;
+				return message.messageSummary.includes(self.filter);
 			});
 		}
 	},

src/main/zapHomeFiles/hud/tools/break.js

@@ -136,7 +136,7 @@ const Break = (function () {
 
 		utils.getAllClients('display')
 			.then(clients => {
-				const isFirefox = this.navigator.userAgent.indexOf('Firefox') > -1;
+				const isFirefox = this.navigator.userAgent.includes('Firefox');
 				let r = false;
 
 				if (isFirefox) {
@@ -198,7 +198,7 @@ const Break = (function () {
 	function showBreakWebSocketDisplay(data) {
 		utils.getAllClients('display')
 			.then(clients => {
-				const isFirefox = this.navigator.userAgent.indexOf('Firefox') > -1;
+				const isFirefox = this.navigator.userAgent.includes('Firefox');
 				let r = false;
 
 				if (isFirefox) {

src/main/zapHomeFiles/hud/utils.js

@@ -58,7 +58,7 @@ const utils = (function () {
 			headerText = headerText.substring(headerText.indexOf(':') + 2);
 			let value;
 
-			if (headerText.indexOf('\n') < 0) {
+			if (!headerText.includes('\n')) {
 				value = headerText;
 				headerText = '';
 			} else {
@@ -125,7 +125,7 @@ const utils = (function () {
 	}
 
 	function hasScheme(url) {
-		return url.indexOf('://') > -1;
+		return url.includes('://');
 	}
 
 	/*
@@ -152,7 +152,7 @@ const utils = (function () {
 	 * Initialize all of the info that will be stored in indexeddb.
 	 */
 	function initializeHUD(leftTools, rightTools, drawer) {
-		if (IS_DEV_MODE && leftTools.indexOf('hudErrors') < 0) {
+		if (IS_DEV_MODE && !leftTools.includes('hudErrors')) {
 			// Always add the error tool in dev mode
 			leftTools.push('hudErrors');
 		}