Fix remaining typing issues

Author: ftilde

learning_loop_node/tests/detector/conftest.py

@@ -16,7 +16,7 @@
 import socketio
 import uvicorn
 
-from learning_loop_node.data_classes import BoxDetection, ImageMetadata, ModelInformation
+from learning_loop_node.data_classes import BoxDetection, ImageMetadata, ImagesMetadata, ModelInformation
 from learning_loop_node.detector.detector_logic import DetectorLogic
 
 from ...detector.detector_node import DetectorNode
@@ -142,7 +142,7 @@ def get_outbox_files(outbox: Outbox):
     return [file for file in files if os.path.isfile(file)]
 
 
-class MockDetectorLogic(DetectorLogic):  # pylint: disable=abstract-method
+class MockDetectorLogic(DetectorLogic):
 
     def __init__(self, model_info: ModelInformation):
         self.image_metadata = ImageMetadata(
@@ -155,6 +155,9 @@ def __init__(self, model_info: ModelInformation):
     def evaluate(self, image: np.ndarray) -> ImageMetadata:
         return self.image_metadata
 
+    def batch_evaluate(self, images: list[np.ndarray]) -> ImagesMetadata:
+        raise NotImplementedError()
+
 
 class MockDetectorFactory:
     model_format = 'mock'

learning_loop_node/tests/detector/test_client_communication.py

@@ -8,7 +8,7 @@
 from PIL import Image
 
 from ...data_classes import ModelInformation
-from ...detector.detector_node import DetectorNode
+from ...detector.detector_node import DetectorNode, _ActiveDetector
 from ...globals import GLOBALS
 from .conftest import get_outbox_files
 from .testing_detector import TestingDetectorLogic
@@ -20,6 +20,7 @@
 @pytest.mark.asyncio
 async def test_detector_path(test_detector_node: DetectorNode):
     assert test_detector_node.outbox.path.startswith('/tmp')
+    assert isinstance(test_detector_node._detector, _ActiveDetector)  # pylint: disable=protected-access
     assert isinstance(test_detector_node._detector.logic, TestingDetectorLogic)  # pylint: disable=protected-access
 
 # pylint: disable=unused-argument

learning_loop_node/tests/detector/test_relevance_filter.py

@@ -6,7 +6,7 @@
 from PIL import Image
 
 from ...data_classes import BoxDetection, ImageMetadata, PointDetection
-from ...detector.detector_node import DetectorNode
+from ...detector.detector_node import DetectorNode, _ActiveDetector
 from .conftest import get_outbox_files
 from .testing_detector import TestingDetectorLogic
 
@@ -19,6 +19,7 @@ async def test_filter_is_used_by_node(test_detector_node: DetectorNode, autouplo
     """Test if filtering is used by the node. In particular, when upload is filtered, the identical detections should not be uploaded twice.
     Note thatt we have to mock the dummy detections to only return a point and a box detection."""
 
+    assert isinstance(test_detector_node._detector, _ActiveDetector)  # pylint: disable=protected-access
     assert isinstance(test_detector_node._detector.logic, TestingDetectorLogic)  # pylint: disable=protected-access
     test_detector_node._detector.logic.det_to_return = ImageMetadata(  # pylint: disable=protected-access
         box_detections=[