Skip to content

Commit be198fc

Browse files
improve dialog test
1 parent 6b2df93 commit be198fc

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

tests/test_dialog.py

+9-10
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from typing import List
2-
31
from selenium.webdriver.common.keys import Keys
42

53
from nicegui import ui
@@ -24,22 +22,23 @@ def test_open_close_dialog(screen: Screen):
2422

2523
def test_await_dialog(screen: Screen):
2624
with ui.dialog() as dialog, ui.card():
27-
ui.label('Are you sure?')
28-
with ui.row():
29-
ui.button('Yes', on_click=lambda: dialog.submit('Yes'))
30-
ui.button('No', on_click=lambda: dialog.submit('No'))
25+
ui.button('Yes', on_click=lambda: dialog.submit('Yes'))
26+
ui.button('No', on_click=lambda: dialog.submit('No'))
3127

3228
async def show() -> None:
33-
results.append(await dialog)
34-
results: List[str] = []
29+
ui.notify(f'Result: {await dialog}')
30+
3531
ui.button('Open', on_click=show)
3632

3733
screen.open('/')
3834
screen.click('Open')
3935
screen.click('Yes')
36+
screen.should_contain('Result: Yes')
37+
4038
screen.click('Open')
4139
screen.click('No')
40+
screen.should_contain('Result: No')
41+
4242
screen.click('Open')
4343
screen.type(Keys.ESCAPE)
44-
screen.wait(0.5)
45-
assert results == ['Yes', 'No', None]
44+
screen.should_contain('Result: None')

0 commit comments

Comments
 (0)