Skip to content

Size assumptions in parsing code don't hold for regtest blocks #18

Open
@str4d

Description

@str4d

The code below will write an incorrect block if the Equihash parameters are different from mainnet (e.g. for regtest blocks):

https://github.com/zcash-hackworks/lightwalletd/blob/3071b5759ae5b7651d5d13c664e5eb2f5bf503f3/parser/block_header.go#L75-L77

The read side does correctly handle the length:

https://github.com/zcash-hackworks/lightwalletd/blob/3071b5759ae5b7651d5d13c664e5eb2f5bf503f3/parser/block_header.go#L124-L126

Metadata

Metadata

Assignees

No one assigned

    Labels

    invalidThis doesn't seem rightnice to haveDefinitely not a blocker

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions