Skip to content

Copy doc/zinit.1 only if it exists. Fixes #418. #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

psprint
Copy link
Contributor

@psprint psprint commented Nov 8, 2022

Description

Some distributions don't provide zinit.1 man page, so first check if it's available.

Motivation and Context

To fix #418.

Related Issue(s)

#418

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions github-actions bot added the zinit label Nov 8, 2022
@alichtman alichtman merged commit 4c94ad2 into zdharma-continuum:main Nov 18, 2022
@alichtman
Copy link
Member

alichtman commented Nov 18, 2022

Seems like a reasonable fix?

Edit: I read the linked issue and the patch again and I'm not sure that this fixes the actual issue. I'd like to understand exactly why this is happening before merging a fix.

That manpage has been in doc/zinit.1 for a while. And the archive I downloaded from https://github.com/zdharma-continuum/zinit/archive/refs/tags/v3.8.0.tar.gz has doc/zinit.1.

Wasn't right to merge this.

@github-actions
Copy link

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: cannot stat 'path/to/zinit/doc/zinit.1'
2 participants