feat: search by filtering trash files (#19)

* feat: search by filtering trash files
* test: add test for search filter

Author: zdk

rm-safely

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-VERSION="1.7.0"
+VERSION="1.8.0"
 HOOK_FILE="$HOME/.rm-safely"
 
 GREEN='\033[0;32m'
@@ -183,8 +183,15 @@ rm() {
             fi
             ;;
         --list-trash|-l)
+            shift
+            local filter_pattern="$1"
             local has_files=0
-            echo "Trash Contents:"
+
+            if [ -n "$filter_pattern" ]; then
+                echo "Trash Contents (filtered by: '$filter_pattern'):"
+            else
+                echo "Trash Contents:"
+            fi
             echo "==============="
             echo "Hash    | Filename                                 | Original Path"
             echo "--------|------------------------------------------|--------------"
@@ -200,8 +207,27 @@ rm() {
                         info_file="$trash_info/${basename}.info"
                         # Generate short hash from filename
                         hash=$(echo -n "$basename" | sha256sum | cut -c1-6)
+
+                        # Get original path
+                        local original_path=""
                         if [ -f "$info_file" ]; then
                             original_path=$(cat "$info_file" 2>/dev/null)
+                        fi
+
+                        # Apply filter if pattern provided
+                        if [ -n "$filter_pattern" ]; then
+                            # Extract original filename by removing timestamp suffix
+                            local original_filename="${basename%_*}"
+
+                            # Case-insensitive match on filename or path
+                            if ! echo "$original_filename" | grep -qi "$filter_pattern" && \
+                               ! echo "$original_path" | grep -qi "$filter_pattern"; then
+                                continue
+                            fi
+                        fi
+
+                        # Display the file
+                        if [ -n "$original_path" ]; then
                             printf "%-7s | %-40s | %s\n" "$hash" "$basename" "$original_path"
                         else
                             printf "%-7s | %-40s | %s\n" "$hash" "$basename" "(unknown)"
@@ -212,7 +238,11 @@ rm() {
             done < <(get_all_trash_dirs)
 
             if [ $has_files -eq 0 ]; then
-                echo "Trash is empty"
+                if [ -n "$filter_pattern" ]; then
+                    echo "No files found matching pattern: '$filter_pattern'"
+                else
+                    echo "Trash is empty"
+                fi
             fi
             ;;
         --undo|-u)
@@ -346,13 +376,23 @@ Files on other filesystems go to <mountpoint>/.Trash-<uid>
 
 Options:
   --rm                      Skip trash!, really execute 'rm'
-  --list-trash, -l          Show trash contents from all filesystems
+  --list-trash [pattern], -l [pattern]
+                            Show trash contents from all filesystems
+                            Optional: filter by pattern (case-insensitive)
   --restore <hash>, -s      Restore a file from trash using its hash
   --undo, -u                Restore the last deleted files
   --empty-trash             Empty all trash directories
   --show-trash-path, -p     Display all trash directory paths
   --version                 Show version information
   --help                    Show this help
+
+Examples:
+  rm file.txt               Move file to trash
+  rm -l                     List all files in trash
+  rm -l ".js"               List only JavaScript files in trash
+  rm -l "project"           List files with "project" in name or path
+  rm -s a1b2c3              Restore file with hash a1b2c3
+  rm -u                     Undo last deletion
 HELP
             ;;
         *)

test_e2e.sh

@@ -239,6 +239,84 @@ else
     print_fail "Should show trash path"
 fi
 
+print_scenario "Search/Filter Trash Contents"
+
+print_test "Create files with unique patterns for filter testing"
+echo "project code" >uniqueproject123_config.js
+echo "app code" >uniqueapp456_settings.json
+echo "readme text" >uniqueREADME789.md
+echo "test code" >uniquehelper999_test.py
+rm uniqueproject123_config.js uniqueapp456_settings.json uniqueREADME789.md uniquehelper999_test.py
+print_pass "Created and deleted 4 files with unique patterns"
+
+print_test "Filter by filename pattern - includes match"
+filter_output=$(rm --list-trash "uniqueproject123" 2>&1)
+if echo "$filter_output" | grep -q "uniqueproject123_config.js"; then
+    print_pass "Filter includes matching file (uniqueproject123)"
+else
+    print_fail "Filter should show uniqueproject123_config.js"
+fi
+
+print_test "Filter by filename pattern - excludes non-match"
+filter_output=$(rm --list-trash "uniqueproject123" 2>&1)
+if ! echo "$filter_output" | grep -q "uniqueapp456_settings.json"; then
+    print_pass "Filter excludes non-matching file"
+else
+    print_fail "Filter should not show uniqueapp456_settings.json when filtering by uniqueproject123"
+fi
+
+print_test "Filter with different unique pattern"
+filter_output=$(rm --list-trash "helper999" 2>&1)
+if echo "$filter_output" | grep -q "uniquehelper999_test.py"; then
+    print_pass "Filter shows matching file (helper999)"
+else
+    print_fail "Filter should show uniquehelper999_test.py"
+fi
+
+print_test "Filter with file extension pattern"
+filter_output=$(rm --list-trash "uniqueREADME789.md" 2>&1)
+if echo "$filter_output" | grep -q "uniqueREADME789.md" && \
+   ! echo "$filter_output" | grep -q "uniquehelper999_test.py"; then
+    print_pass "Filter matches specific markdown file"
+else
+    print_fail "Filter should show uniqueREADME789.md but not .py files"
+fi
+
+print_test "Filter with guaranteed no matches"
+filter_output=$(rm --list-trash "xYz123NoMatchEver456" 2>&1)
+if echo "$filter_output" | grep -q "No files found matching pattern"; then
+    print_pass "Filter correctly reports no matches"
+else
+    print_fail "Should show 'No files found' message for non-existent pattern"
+fi
+
+print_test "Case-insensitive filter test (uppercase)"
+filter_output=$(rm --list-trash "UNIQUEREADME789" 2>&1)
+if echo "$filter_output" | grep -q "uniqueREADME789.md"; then
+    print_pass "Filter is case-insensitive (uppercase pattern)"
+else
+    print_fail "Filter should match uniqueREADME789.md with uppercase pattern"
+fi
+
+print_test "Case-insensitive filter test (lowercase)"
+filter_output=$(rm --list-trash "uniquereadme789" 2>&1)
+if echo "$filter_output" | grep -q "uniqueREADME789.md"; then
+    print_pass "Filter is case-insensitive (lowercase pattern)"
+else
+    print_fail "Filter should match uniqueREADME789.md with lowercase pattern"
+fi
+
+print_test "List all trash without filter shows test files"
+list_output=$(rm --list-trash 2>&1)
+if echo "$list_output" | grep -q "uniqueproject123_config.js" && \
+   echo "$list_output" | grep -q "uniqueapp456_settings.json" && \
+   echo "$list_output" | grep -q "uniqueREADME789.md" && \
+   echo "$list_output" | grep -q "uniquehelper999_test.py"; then
+    print_pass "Listing all trash shows all test files"
+else
+    print_fail "Should show all test files when no filter is provided"
+fi
+
 print_scenario "Direct Deletion (Bypass Trash)"
 print_test "Create file for permanent deletion"
 echo "disposable" >disposable.txt