Skip to content

Commit c4726c3

Browse files
fix(llmisvc): align customizeManagerOptions hook to return error (opendatahub-io#1374)
* fix(llmisvc): align customizeManagerOptions hook to return error Upstream kserve#5240 changed customizeManagerOptions to return an error, consistent with the other distro hooks (extendControllerSetup, reconcileRouterPlatformNetworking). Aligns both the default no-op and the OCP implementation to the updated signature, and adds error handling at the call site in main. * fix: precommit --------- Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
1 parent c113074 commit c4726c3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

cmd/llmisvc/manager_options_ocp.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ func customizeManagerOptions(opts *ctrl.Options) error {
3838
if labelSel == nil {
3939
labelSel = cfg.Namespaces[cache.AllNamespaces].LabelSelector
4040
}
41+
4142
opts.Cache.ByObject[obj] = cache.ByObject{
4243
Namespaces: map[string]cache.Config{
4344
llmisvc.ServiceCASigningSecretNamespace: {
@@ -50,6 +51,7 @@ func customizeManagerOptions(opts *ctrl.Options) error {
5051
},
5152
},
5253
}
54+
5355
return nil
5456
}
5557

0 commit comments

Comments
 (0)