-
Notifications
You must be signed in to change notification settings - Fork 10
Description
The definitions laid out in https://github.com/zededa/terraform-provider-zedcloud/blob/main/schemas/application_instance.go#L480 do not match API requirements.
For example name is flagged as Optional meaning leaving out the name variable when defining an application interface block passes validation. But running apply results in an error from the API due to an empty name field.
name should also have the ForceNew tag applied. Currently if an application is renamed, the state becomes broken with an unfound resource. When instead renaming can be expected to destroy the resource, and then create a new one (as name cannot be changed).
Other attributes are also marked as optional, when not including them causes the API to return errors. It also seems many attributes get set by the API, but are not marked as Computed, meaning every terraform plan/apply after shows changes as terraform tries to override the settings.