d_a_obj_crvhahen matching (#2564)

* useHeapInit 73%, ctor and dtor 100%, Delete 94%, wallcheck 43%, create 42%

* useHeapInit 100%

* Wall_Check 85%

* Update fields and return types

* crvhahen Wall_Check and Execute 100

* update createheap return type for matching

* crvhahen create 70 draw 57

* Revert change that made useHeapInit non-matching

* delete matching, .rodata 91

* create 94%

* crvhahen draw 85%

* setBaseMtx matching

* CheckCull and checkViewArea 100%

* rename & cleanup fields

* cleanup fields, rodata. hahenset and hahen_hakai partials

* cleanup and remove SECTION_RODATA

* d_a_obj_crvhahen OK

* cleanup and fix various inconsistancies or issues

---------

Co-authored-by: StuckInLimbo <tbosley@limbofps.net>

Author: StuckInLimbo

configure.py

@@ -1905,7 +1905,7 @@ def MatchingFor(*versions) -> bool:
     ActorRel(NonMatching, "d_a_obj_crope"),
     ActorRel(NonMatching, "d_a_obj_crvfence"),
     ActorRel(MatchingFor("GZ2E01"), "d_a_obj_crvgate"),
-    ActorRel(NonMatching, "d_a_obj_crvhahen"),
+    ActorRel(MatchingFor("GZ2E01"), "d_a_obj_crvhahen"),
     ActorRel(NonMatching, "d_a_obj_crvlh_down"),
     ActorRel(NonMatching, "d_a_obj_crvlh_up"),
     ActorRel(MatchingFor("GZ2E01"), "d_a_obj_crvsteel"),

include/d/actor/d_a_obj_crvhahen.h

@@ -1,33 +1,54 @@
 #ifndef D_A_OBJ_CRVHAHEN_H
 #define D_A_OBJ_CRVHAHEN_H
 
+#include "d/d_com_inf_game.h"
 #include "f_op/f_op_actor_mng.h"
+#include "m_Do/m_Do_ext.h"
+#include "m_Do/m_Do_lib.h"
 
 /**
  * @ingroup actors-objects
  * @class daObjCRVHAHEN_c
- * @brief Caravan Wood
+ * @brief Bulblin Camp Caraven Wooden Fence Fragments
  *
- * @details
+ * @details Hahen (はへん) a fragment, shard, or splinter.
+ * physics-enabled shards or fragments that simulate debris from destruction.
  *
  */
 class daObjCRVHAHEN_c : public fopAc_ac_c {
 public:
-    /* 80BD342C */ void HahenSet(cXyz, cXyz, cXyz, cXyz, f32);
-    /* 80BD3628 */ void Wall_Check(cXyz, cXyz);
+    /* 80BD342C */ int HahenSet(cXyz, cXyz, cXyz, cXyz, f32);
+    /* 80BD3628 */ bool Wall_Check(cXyz, cXyz);
     /* 80BD3720 */ void Hahen_Hakai(int, int);
     /* 80BD38DC */ void CheckCull();
-    /* 80BD3A9C */ void checkViewArea(cXyz*);
-    /* 80BD3B20 */ void Execute();
-    /* 80BD3B74 */ void Delete();
+    /* 80BD3A9C */ bool checkViewArea(cXyz*);
+    /* 80BD3B20 */ int Execute();
+    /* 80BD3B74 */ int Delete();
     /* 80BD3C0C */ void setBaseMtx();
-    /* 80BD3DBC */ void create();
+    /* 80BD3DBC */ int create();
 
-private:
-    /* 0x568 */ u8 field_0x568[0x794 - 0x568];
+    /* 80BD3338 */ int CreateHeap();
+    /* 80BD3CA0 */ int Draw();
+
+    /* 0x568 */ cXyz mPos[10];
+    /* 0x5e0 */ cXyz mVelocity[10];
+    /* 0x658 */ cXyz mInitialPos[10];
+    /* 0x6d0 */ csXyz mRotation[10];
+    /* 0x70c */ csXyz mRotSpeed[10];
+    /* 0x748 */ u32 mFlags;
+    /* 0x74c */ f32 mGroundHeight;
+    /* 0x750 */ bool mDrawHahen;
+    /* 0x751 */ u8 mStatus[10];
+    /* 0x75b */ u8 field_0x75b;
+    /* 0x75c */ f32 mTimer;
+    /* 0x760 */ J3DModel* mpModel[10];
+    /* 0x788 */ request_of_phase_process_class mPhase;
+    /* 0x790 */ u8 mEffectState;
+    /* 0x791 */ bool mInitialized;
+    /* 0x792 */ u8 mCounter;
+    /* 0x793 */ u8 mDrawState;
 };
 
 STATIC_ASSERT(sizeof(daObjCRVHAHEN_c) == 0x794);
 
-
 #endif /* D_A_OBJ_CRVHAHEN_H */