Skip to content

Debug work for d_a_e_rdy to get 0.10% GCN progress#2390

Merged
hatal175 merged 3 commits intozeldaret:mainfrom
YunataSavior:dbg_d_a_e_rdy
Apr 19, 2025
Merged

Debug work for d_a_e_rdy to get 0.10% GCN progress#2390
hatal175 merged 3 commits intozeldaret:mainfrom
YunataSavior:dbg_d_a_e_rdy

Conversation

@YunataSavior
Copy link
Copy Markdown
Contributor

Using the debug build, I attempted to solve d_a_e_rdy's regalloc issues. I managed to get some functions to match, and demo_camera matches more closely, but some regalloc issues remain. For the functions which continue to have regalloc issues, they mostly match on debug, so IDK what else can be done.

These C-style TUs are very frustrating....

Copy link
Copy Markdown
Contributor

@TakaRikka TakaRikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks fine, only thing is for debug differences that aren't related to debug features, i'd use a #if VERSION != VERSION_SHIELD_DEBUG check instead since we'll want to have a debug define that only changes whether debug features are enabled or not, not version differences

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Apr 19, 2025

Report for GZ2E01 (f63b2db - 0355c0d)

📈 Matched code: 56.81% (+0%, +11676 bytes)

d_a_e_rdy/d/actor/d_a_e_rdy | nodeCallBack(J3DJoint*, int) +36 bytes -> 100.00%
📈 d_a_e_rdy/d/actor/d_a_e_rdy | search_bomb(e_rdy_class*, int) +148 bytes -> 85.56%
d_a_e_rdy/d/actor/d_a_e_rdy | e_rdy_fight_run(e_rdy_class*) +9 bytes -> 100.00%
d_a_e_rdy/d/actor/d_a_e_rdy | e_rdy_damage(e_rdy_class*) +25 bytes -> 100.00%
d_a_e_rdy/d/actor/d_a_e_rdy | s_bikkuri_sub(void*, void*) +76 bytes -> 100.00%
d_a_e_rdy/d/actor/d_a_e_rdy | action(e_rdy_class*) +32 bytes -> 100.00%
📈 d_a_e_rdy/d/actor/d_a_e_rdy | demo_camera(e_rdy_class*) +1083 bytes -> 96.73%
📈 d_a_e_rdy/d/actor/d_a_e_rdy | daE_RDY_Execute(e_rdy_class*) +84 bytes -> 99.15%

@hatal175 hatal175 merged commit 05d9750 into zeldaret:main Apr 19, 2025
1 check passed
@YunataSavior YunataSavior deleted the dbg_d_a_e_rdy branch May 31, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants