Merged
Conversation
TakaRikka
reviewed
Apr 14, 2025
Contributor
Author
|
Thanks for the review, I implemented all suggestions and cleaned up some more along the way |
TakaRikka
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e_tk_classfopEn_enemy_c8.30 kB (0.07%)First enemy actor. Some of the enums might be unnecessary or wrongly labeled. Could be cleaned up more, but it is a large file. There are two instances of a tmp variable to make load order match. Happy for all suggestions.
The enemy is the Water Toadpoli in the Water Grotto on layer 5, where a lot of them spawn. Also allegedly in Goron Mines - Magnet Wall Room, but I think this is not true.
There is also the Fire Toadpoli,
e_tk_2, which I might do next.Resolves #539.