Merged
Conversation
TakaRikka
reviewed
Apr 19, 2025
include/d/actor/d_a_npc_uri.h
Outdated
| STATIC_ASSERT(sizeof(daNpc_Uri_c) == 0x1018); | ||
|
|
||
| struct daNpc_Uri_HIOParam { | ||
| /* 0x00 */ f32 field_0x00; // 200.0f |
Contributor
There was a problem hiding this comment.
instead of putting the float values as comments here, i'd rather put a comment in the actual data initializer with the name of each value. reasoning being the values are supposed to be tweaked and such, while the names arent
src/d/actor/d_a_npc_uri.cpp
Outdated
| mDoMtx_stack_c::ZrotM(mStagger.getAngleX(0)); | ||
| } | ||
|
|
||
| if ((f32)0.0 < field_0x1004) { |
Contributor
There was a problem hiding this comment.
why the cast instead of 0.0f?
src/d/actor/d_a_npc_uri.cpp
Outdated
| void daNpc_Uri_c::chkPlayerGetWoodShield() { | ||
| // NONMATCHING | ||
| BOOL daNpc_Uri_c::chkPlayerGetWoodShield() { | ||
| return g_dComIfG_gameInfo.info.getPlayer().getCollect().isCollect(2, 0); |
Contributor
There was a problem hiding this comment.
should use dComIfGs_isCollectShield in here
src/d/actor/d_a_npc_uri.cpp
Outdated
| if (talkProc(NULL, 0, NULL, 0) && mFlow.checkEndFlow() && | ||
| (s32)mFlow.getEventId(&local_48) == 1) | ||
| { | ||
| if (mItemId == -1) { |
Contributor
There was a problem hiding this comment.
since it's an actor ID, you can use fpcM_ERROR_PROCESS_ID_e
src/d/actor/d_a_npc_uri.cpp
Outdated
Comment on lines
1861
to
1876
| s32 daNpc_Uri_c::getBackboneJointNo() { | ||
| return 1; | ||
| } | ||
|
|
||
| /* 80B2CD64-80B2CD74 0066A4 0010+00 1/0 0/0 0/0 .text checkChangeJoint__11daNpc_Uri_cFi | ||
| */ | ||
| void daNpc_Uri_c::checkChangeJoint(int param_0) { | ||
| // NONMATCHING | ||
| BOOL daNpc_Uri_c::checkChangeJoint(int param_0) { | ||
| return param_0 == 4; | ||
| } | ||
|
|
||
| /* 80B2CD74-80B2CD84 0066B4 0010+00 1/0 0/0 0/0 .text checkRemoveJoint__11daNpc_Uri_cFi | ||
| */ | ||
| void daNpc_Uri_c::checkRemoveJoint(int param_0) { | ||
| // NONMATCHING | ||
| BOOL daNpc_Uri_c::checkRemoveJoint(int param_0) { | ||
| return param_0 == 8; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
with these small funcs being all the way here at the end of the TU, i have a strong suspicion they are supposed to be inlined weak functions
Report for GZ2E01 (c5f9d8d - 880a10b)Changes
|
hatal175
approved these changes
Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#725