Skip to content

d_ev_camera work#2412

Merged
TakaRikka merged 12 commits intozeldaret:mainfrom
carter-ktb21:d_ev_camera
Apr 30, 2025
Merged

d_ev_camera work#2412
TakaRikka merged 12 commits intozeldaret:mainfrom
carter-ktb21:d_ev_camera

Conversation

@carter-ktb21
Copy link
Copy Markdown
Contributor

Putting in a draft because I fully expect to have to rework some parts of my changes due to the confusing nature of the class

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Apr 27, 2025

Report for GZ2E01 (7e06b18 - 1fc3a46)

📈 Matched code: 58.03% (+0.04%, +4716 bytes)

framework/d/d_ev_camera | @unnamed@d_ev_camera_cpp@::isStageEvent(int) +132 bytes -> 100.00%
📈 framework/d/d_ev_camera | dCamera_c::fixedFrameEvCamera() +3308 bytes -> 98.34%
📈 framework/d/d_ev_camera | dCamera_c::stokerEvCamera() +860 bytes -> 76.87%
framework/d/d_ev_camera | dCamera_c::rollingEvCamera() +4152 bytes -> 100.00%
📈 framework/d/d_ev_camera | dCamera_c::fixedPositionEvCamera() +944 bytes -> 82.58%
📈 framework/d/d_ev_camera | dCamera_c::transEvCamera(int) +5875 bytes -> 56.41%
framework/d/d_ev_camera | @unnamed@d_ev_camera_cpp@::isRelChar(char) +36 bytes -> 100.00%
framework/d/d_ev_camera | cSGlobe::operator=(const cSGlobe&) +28 bytes -> 100.00%
framework/d/d_ev_camera | cXyz::abs() const +260 bytes -> 100.00%
framework/d/d_ev_camera | cSGlobe::U(const cSAngle&) +60 bytes -> 100.00%
📈 framework/d/d_ev_camera | cXyz::operator-=(const Vec&) +32 bytes -> 61.54%
framework/d/d_ev_camera | cXyz::operator+=(const Vec&) +52 bytes -> 100.00%
📈 framework/d/d_ev_camera | dCamera_c::watchActorEvCamera() +2800 bytes -> 63.94%
framework/d/d_ev_camera | cSGlobe::V(const cSAngle&) +60 bytes -> 100.00%
framework/d/d_ev_camera | @unnamed@d_ev_camera_cpp@::lineCollisionCheck(cXyz, cXyz, fopAc_ac_c*, fopAc_ac_c*, fopAc_ac_c*) +84 bytes -> 100.00%
📈 framework/d/d_ev_camera | dCamera_c::restorePosEvCamera() +1283 bytes -> 76.85%
📈 framework/d/d_ev_camera | dCamera_c::gameOverEvCamera() +2200 bytes -> 56.17%
📈 framework/d/d_ev_camera | dCamera_c::tactEvCamera() +2179 bytes -> 56.82%
framework/d/d_ev_camera | dComIfGp_saveCameraPosition(int, cXyz*, cXyz*, float, short) +76 bytes -> 100.00%
📈 framework/d/d_ev_camera | dCamera_c::loadEvCamera() +917 bytes -> 87.12%
📉 framework/d/d_ev_camera | dCamera_c::useItem0EvCamera() -4 bytes -> 0.00%
📈 framework/d/d_ev_camera | dCamera_c::bSplineEvCamera() +521 bytes -> 78.92%
📈 framework/d/d_ev_camera | dCamera_c::twoActor0EvCamera() +1860 bytes -> 95.88%
framework/d/d_ev_camera | dCamera_c::peepHoleEvCamera() +336 bytes -> 100.00%
📈 framework/d/d_ev_camera | __sinit_d_ev_camera_cpp +64 bytes -> 53.12%
📉 framework/d/d_camera | dCamera_c::dCamera_c(camera_class*) -8 bytes -> 98.61%

@carter-ktb21 carter-ktb21 marked this pull request as ready for review April 29, 2025 17:33
@TakaRikka TakaRikka merged commit 497c9c4 into zeldaret:main Apr 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants