Skip to content

d_a_cstatue Matching#2419

Merged
hatal175 merged 7 commits intozeldaret:mainfrom
soruh:d_a_cstatue
May 5, 2025
Merged

d_a_cstatue Matching#2419
hatal175 merged 7 commits intozeldaret:mainfrom
soruh:d_a_cstatue

Conversation

@soruh
Copy link
Copy Markdown
Contributor

@soruh soruh commented May 4, 2025

No description provided.

@soruh soruh changed the title d_a_cstatue Matchinbg d_a_cstatue Matching May 4, 2025
@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented May 4, 2025

Report for GZ2E01 (211e5f1 - c692c35)

📈 Matched code: 58.82% (+0.39%, +44444 bytes)
📈 Linked code: 26.15% (+0.36%, +40924 bytes)

d_a_cstaF/d/actor/d_a_cstaF | dBgS_StatueAcch::~dBgS_StatueAcch() +108 bytes -> 100.00%
📈 d_a_cstaF/d/actor/d_a_cstaF | daCstaF_c::~daCstaF_c() +88 bytes -> 91.24%
d_a_cstaF/d/actor/d_a_cstaF | @36@__dt__15dBgS_StatueAcchFv +8 bytes -> 100.00%
d_a_cstaF/d/actor/d_a_cstaF | @20@__dt__15dBgS_StatueAcchFv +8 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::c_list::draw() +73 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_createHeap(fopAc_ac_c*) +28 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::createHeap() +733 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::create() +121 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::destroy() +76 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::draw() +173 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::execute() +56 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::drawMeter() +857 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::initiate() +48 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::update() +556 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::setBrkAnime(bool) +441 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_create(daCoach2D_c*) +133 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_destroy(daCoach2D_c*) +28 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_execute(daCoach2D_c*) +28 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_draw(daCoach2D_c*) +28 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_HIO_c::~daCoach2D_HIO_c() +32 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | mDoHIO_entry_c::~mDoHIO_entry_c() +68 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::c_list::~c_list() +13 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | daCoach2D_c::~daCoach2D_c() +36 bytes -> 100.00%
d_a_coach_2D/d/actor/d_a_coach_2D | __sinit_d_a_coach_2D_cpp +113 bytes -> 100.00%
d_a_cstatue/d/actor/d_a_cstatue | daCstatue_c::atHitCallback(fopAc_ac_c*) +24 bytes -> 100.00%
d_a_cstatue/d/actor/d_a_cstatue | daCstatue_atHitCallback(fopAc_ac_c*, dCcD_GObjInf*, fopAc_ac_c*, dCcD_GObjInf*) +32 bytes -> 100.00%
d_a_cstatue/d/actor/d_a_cstatue | daCstatue_c::createHeap() +948 bytes -> 100.00%
d_a_cstatue/d/actor/d_a_cstatue | cXyz::~cXyz() +56 bytes -> 100.00%
d_a_cstatue/d/actor/d_a_cstatue | dCcD_Sph::~dCcD_Sph() +200 bytes -> 100.00%
d_a_cstatue/d/actor/d_a_cstatue | dCcD_Sph::dCcD_Sph() +129 bytes -> 100.00%
...and 106 more items

@soruh
Copy link
Copy Markdown
Contributor Author

soruh commented May 4, 2025

It seems the condition on checkNotSmallType in procCopyRodSwingInit was de Morganed incorrectly and the inline was thus also inverted. So fixing the inline broke procCopyRodSwingInit.

@hatal175 hatal175 merged commit 885981c into zeldaret:main May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants