d_a_npc_seib almost equivalent by carter-ktb21 · Pull Request #2425 · zeldaret/tp

carter-ktb21 · 2025-05-07T16:35:48Z

No description provided.

decomp-dev · 2025-05-07T16:43:07Z

Report for GZ2E01 (`38c4252` - `78e776c`)

📈 Matched code: 59.25% (+0.42%, +48112 bytes)
📈 Linked code: 26.28% (+0.13%, +14640 bytes)

✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_actor::do_paragraph(unsigned long, const void*, unsigned long) +845 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_ambientLight::do_paragraph(unsigned long, const void*, unsigned long) +225 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_camera::do_paragraph(unsigned long, const void*, unsigned long) +705 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_fog::do_paragraph(unsigned long, const void*, unsigned long) +236 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_light::do_paragraph(unsigned long, const void*, unsigned long) +568 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_message::do_paragraph(unsigned long, const void*, unsigned long) +12 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_particle::do_paragraph(unsigned long, const void*, unsigned long) +912 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_sound::do_paragraph(unsigned long, const void*, unsigned long) +808 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_sound::~TObject_sound() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_particle::~TObject_particle() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_message::~TObject_message() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_light::~TObject_light() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_fog::~TObject_fog() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_camera::~TObject_camera() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_ambientLight::~TObject_ambientLight() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::TObject_actor::~TObject_actor() +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | __sinit_jstudio-object_cpp +928 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_sound>::~TOutputVariableValue_BOOL_() +96 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_particle>::~TOutputVariableValue_BOOL_() +96 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_light>::~TOutputVariableValue_BOOL_() +96 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_camera>::~TOutputVariableValue_BOOL_() +96 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_actor>::~TOutputVariableValue_BOOL_() +96 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_sound>::operator()(float, JStudio::TAdaptor*) const +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_particle>::operator()(float, JStudio::TAdaptor*) const +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_light>::operator()(float, JStudio::TAdaptor*) const +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_camera>::operator()(float, JStudio::TAdaptor*) const +92 bytes -> 100.00%
✅ framework/JSystem/JStudio/JStudio/jstudio-object | JStudio::@unnamed@jstudio_object_cpp@::TOutputVariableValue_BOOL_<JStudio::TAdaptor_actor>::operator()(float, JStudio::TAdaptor*) const +92 bytes -> 100.00%
✅ d_a_obj_yousei/d/actor/d_a_obj_yousei | daObjYOUSEI_c::InitCcSph() +105 bytes -> 100.00%
✅ d_a_obj_yousei/d/actor/d_a_obj_yousei | daObjYOUSEI_c::SetCcSph() +85 bytes -> 100.00%
✅ d_a_obj_yousei/d/actor/d_a_obj_yousei | useHeapInit(fopAc_ac_c*) +220 bytes -> 100.00%
...and 128 more items

TakaRikka · 2025-05-08T03:01:34Z

src/d/actor/d_a_npc_seib.cpp

+    if (mdlData_p == NULL) {
+        JUTAssertion::showAssert(JUTAssertion::getSDevice(), "d_a_npc_seib.cpp", 0x1d2, "0 != mdlData_p");
+    }


JUT_ASSERT(466, 0 != mdlData_p);

TakaRikka · 2025-05-08T03:01:56Z

src/d/actor/d_a_npc_seib.cpp

-void daNpc_seiB_c::getType() {
-    // NONMATCHING
+u8 daNpc_seiB_c::getType() {
+    switch ((u8)fopAcM_GetParam(this)) {


fopAcM_GetParam(this) & 0xFF ?

TakaRikka · 2025-05-08T03:03:29Z

src/d/actor/d_a_npc_seib.cpp

+    #ifdef DEBUG
+    JUTAssertion::showAssert(JUTAssertion::getSDevice(), "d_a_npc_seib.cpp", 0x42c, "0");
+    OSPanic("d_a_npc_seib.cpp", 0x42c, "Halt");
+    #endif


JUT_ASSERT(1068, 0);

TakaRikka · 2025-05-08T03:04:21Z

src/d/actor/d_a_npc_seib.cpp

-static void daNpc_seiB_Create(void* param_0) {
-    // NONMATCHING
+static int daNpc_seiB_Create(void* param_0) {
+    daNpc_seiB_c* i_this;


forgetting to actually cast param_0 in these?

* Work on create function * d_a_npc_seib mostly finished * Pull request cleanup * Extra new line removed --------- Co-authored-by: hatal175 <hatal175@users.noreply.github.com>

carter-ktb21 added 3 commits May 5, 2025 15:24

Work on create function

29df2f4

Merge branch 'main' of https://github.com/zeldaret/tp into d_a_npc_seib

762094b

d_a_npc_seib mostly finished

51587dc

TakaRikka reviewed May 8, 2025

View reviewed changes

carter-ktb21 and others added 2 commits May 8, 2025 07:51

Pull request cleanup

5083b81

Extra new line removed

78e776c

hatal175 approved these changes May 8, 2025

View reviewed changes

hatal175 merged commit a9c9781 into zeldaret:main May 8, 2025
1 check passed

ItsNiklas mentioned this pull request May 9, 2025

d_a_npc_seib Equivalent (weak func order) #2431

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

d_a_npc_seib almost equivalent#2425

d_a_npc_seib almost equivalent#2425
hatal175 merged 5 commits intozeldaret:mainfrom
carter-ktb21:d_a_npc_seib

carter-ktb21 commented May 7, 2025

Uh oh!

decomp-dev bot commented May 7, 2025 •

edited

Loading

Uh oh!

TakaRikka May 8, 2025

Uh oh!

TakaRikka May 8, 2025

Uh oh!

TakaRikka May 8, 2025

Uh oh!

TakaRikka May 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

carter-ktb21 commented May 7, 2025

Uh oh!

decomp-dev bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for GZ2E01 (38c4252 - 78e776c)

Uh oh!

TakaRikka May 8, 2025

Choose a reason for hiding this comment

Uh oh!

TakaRikka May 8, 2025

Choose a reason for hiding this comment

Uh oh!

TakaRikka May 8, 2025

Choose a reason for hiding this comment

Uh oh!

TakaRikka May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

decomp-dev bot commented May 7, 2025 •

edited

Loading

Report for GZ2E01 (`38c4252` - `78e776c`)