Conversation
Report for GZ2E01 (958916a - e84994f)📈 Matched code: 59.90% (+0.02%, +2144 bytes) ✅ |
include/d/actor/d_a_obj_brakeeff.h
Outdated
| public: | ||
| /* 0x568 */ request_of_phase_process_class mRequestOfPhase; | ||
| /* 0x570 */ unsigned char mEffectType; | ||
| //alignment bytes /* 0x571 */ u8 padding_0x571[3]; |
There was a problem hiding this comment.
No need for alignment comments
include/d/actor/d_a_obj_brakeeff.h
Outdated
| /* 0x704 */ u8 padding_0x704[4]; | ||
| /* 0x708 */ Mtx mStoredMatrix; | ||
| /* 0x738 */ dBgW* mpDBgW; | ||
|
|
There was a problem hiding this comment.
Remove unnecessary new lines
include/d/actor/d_a_obj_brakeeff.h
Outdated
| //alignment bytes /* 0x571 */ u8 padding_0x571[3]; | ||
| /* 0x574 */ J3DModel* mpModel; | ||
| /* 0x578 */ mDoExt_brkAnm* mpBrk; | ||
| /* 0x57C */ short mMiscTimer1; |
There was a problem hiding this comment.
Use s16 instead of short (standard in codebase)
include/d/actor/d_a_obj_brakeeff.h
Outdated
| /* 0x568 */ u8 field_0x568[0x73c - 0x568]; | ||
| public: | ||
| /* 0x568 */ request_of_phase_process_class mRequestOfPhase; | ||
| /* 0x570 */ unsigned char mEffectType; |
src/d/actor/d_a_obj_brakeeff.cpp
Outdated
|
|
||
| //model data per effect type | ||
| u32 bef_bmd[2] = { | ||
| 5, 6, |
src/d/actor/d_a_obj_brakeeff.cpp
Outdated
|
|
||
| a_this->mpDBgW->SetCrrFunc(dBgS_MoveBGProc_Typical); | ||
|
|
||
| return 1; |
src/d/actor/d_a_obj_brakeeff.cpp
Outdated
|
|
||
|
|
||
| if(!is_heap_set){ | ||
| return cPhs_ERROR_e; |
src/d/actor/d_a_obj_brakeeff.cpp
Outdated
| } | ||
|
|
||
| if(dComIfG_Bgsp().Regist(a_this->mpDBgW, i_this)){ | ||
| return cPhs_ERROR_e; |
src/d/actor/d_a_obj_brakeeff.cpp
Outdated
| /* 8046E098-8046E0A0 000458 0008+00 1/0 0/0 0/0 .text | ||
| * daObj_Brakeeff_IsDelete__FP18obj_brakeeff_class */ | ||
| static bool daObj_Brakeeff_IsDelete(obj_brakeeff_class* param_0) { | ||
| bool daObj_Brakeeff_IsDelete(obj_brakeeff_class* i_this) { |
There was a problem hiding this comment.
These functions (IsDelete, draw, execute etc return int, so change return type and return 1
|
#953 Resolved |
* Laid out obj_brakeeff_class members * Matched daObj_Brakeeff_Draw * obj_brakeeff::action almost matching * brakeeff_Delete matching * daObj_Brakeeff_Execute matching * work on obj_brakeeff_1 * Matched action and brakeff1 * obj_brakeeff_create almost matching * d_a_obj_brakeeff Matching * d_a_obj_brakeeff additional cleanup * Revert line deleted * Fix tab indentation --------- Co-authored-by: hatal175 <hatal175@users.noreply.github.com>
2 participants
No description provided.