Merged
Conversation
Report for GZ2E01 (e8e3644 - 4e844a8)📈 Matched code: 62.09% (+0.12%, +13512 bytes) ✅ 75 new matches:
...and 45 more new matches |
hatal175
reviewed
May 29, 2025
include/d/actor/d_a_obj_mhole.h
Outdated
|
|
||
| private: | ||
| /* 0x568 */ u8 field_0x568[0x734 - 0x568]; | ||
| /* 0x568 */ u8 field_0x568[0x198]; |
Contributor
There was a problem hiding this comment.
Could you keep the 0x734 - 0x568 convention? makes it easier to add fields later. Same for field_0x701
src/d/actor/d_a_obj_magne_arm.cpp
Outdated
|
|
||
| /* 80592980-8059298C 000000 000C+00 3/3 0/0 0/0 .data cNullVec__6Z2Calc */ | ||
| SECTION_DATA static u8 cNullVec__6Z2Calc[12] = { | ||
| static u8 cNullVec__6Z2Calc[12] = { |
Contributor
There was a problem hiding this comment.
Use UNK_REL_DATA and UNK_REL_BSS for these
hatal175
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.