Skip to content

d_a_npc cleanup#2466

Merged
hatal175 merged 2 commits intozeldaret:mainfrom
TakaRikka:npccleanup
May 31, 2025
Merged

d_a_npc cleanup#2466
hatal175 merged 2 commits intozeldaret:mainfrom
TakaRikka:npccleanup

Conversation

@TakaRikka
Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented May 31, 2025

Report for GZ2E01 (e678f44 - 5ce072f)

📈 Matched code: 62.33% (+0.12%, +13904 bytes)

✅ 35 new matches:
Unit Function Bytes Before After
framework/d/actor/d_a_npc daBaseNpc_chkPnt(cXyz, dPnt*, unsigned short, unsigned short, int, int) +1796 0.22% 100.00%
framework/d/actor/d_a_npc daBaseNpc_putNurbs(dPnt*, int, int, dPnt*, int) +582 4.95% 100.00%
framework/d/actor/d_a_npc daBaseNpc_c::draw(float) +489 0.81% 100.00%
framework/d/actor/d_a_npc daNpcBase_BBasis(int, int, int, int*) +389 1.02% 100.00%
framework/d/actor/d_a_npc daBaseNpc_c::execute() +381 1.04% 100.00%
framework/d/actor/d_a_npc daBaseNpc_c::allAnmPlay() +353 1.12% 100.00%
framework/d/actor/d_a_npc __sinit_d_a_npc_cpp +352 0.00% 100.00%
framework/d/actor/d_a_npc daBaseNpc_c::~daBaseNpc_c() +349 38.18% 100.00%
framework/d/actor/d_a_npc daBaseNpc_c::daBaseNpc_c() +300 36.01% 100.00%
framework/d/actor/d_a_npc daBaseNpc_matAnm_c::calc(J3DMaterial*) const +272 1.45% 100.00%
framework/d/actor/d_a_npc daBaseNpc_moveBgActor_c::MoveBGCreateHeap() +241 1.64% 100.00%
framework/d/actor/d_a_npc daBaseNpc_moveBgActor_c::MoveBGCreate(const char*, int, void (*)(dBgW*, void*, const cBgS_PolyInfo&, bool, cXyz*, csXyz*, csXyz*), unsigned long) +237 1.67% 100.00%
framework/d/actor/d_a_npc daBaseNpc_getGroundAngle(cBgS_PolyInfo*, short) +185 2.13% 100.00%
framework/d/actor/d_a_npc daBaseNpc_moveBgActor_c::MoveBGExecute() +169 2.33% 100.00%
framework/d/actor/d_a_npc daBaseNpc_matAnm_c::~daBaseNpc_matAnm_c() +166 26.23% 100.00%
framework/d/actor/d_a_npc daBaseNpc_PntVsLineSegmentLengthSquare2D(float, float, float, float, float, float, float*, float*, float*) +165 2.38% 100.00%
framework/d/actor/d_a_npc daNpcF_c::chkFindPlayer2(int, short) +148 70.66% 100.00%
framework/d/actor/d_a_npc daBaseNpc_moveBgActor_c::MoveBGDelete() +113 3.45% 100.00%
framework/d/actor/d_a_npc daBaseNpc_c::setMcaMorfAnm(J3DAnmTransformKey*, float, float, int, int, int) +96 4.00% 100.00%
framework/d/actor/d_a_npc daNpcT_Path_c::chkPassed2(cXyz, cXyz*, int, int) +37 97.01% 100.00%
framework/d/actor/d_a_npc cLib_calcTimer<short>(short*) +28 0.00% 100.00%
framework/d/actor/d_a_npc daBaseNpc_lookat_c::~daBaseNpc_lookat_c() +24 88.63% 100.00%
framework/d/actor/d_a_npc daBaseNpc_acMngr_c::daBaseNpc_acMngr_c() +21 16.67% 100.00%
framework/d/actor/d_a_npc daNpcT_JntAnm_c::calc(float) +16 98.39% 100.00%
framework/d/actor/d_a_npc daNpcF_c::getAttnActorP(int, void* (*)(void*, void*), float, float, float, float, short, int, int) +13 98.67% 100.00%
framework/d/actor/d_a_npc daBaseNpc_path_c::daBaseNpc_path_c() +12 25.00% 100.00%
framework/d/actor/d_a_npc daBaseNpc_path_c::~daBaseNpc_path_c() +12 83.33% 100.00%
framework/d/actor/d_a_npc daBaseNpc_acMngr_c::~daBaseNpc_acMngr_c() +12 83.33% 100.00%
framework/d/actor/d_a_npc daNpcF_c::setHitodamaPrtcl() +11 97.84% 100.00%
framework/d/actor/d_a_npc daNpcT_Path_c::chkPassed1(cXyz, int) +9 99.06% 100.00%

...and 5 more new matches

📈 1 improvements in unmatched functions:
Unit Function Bytes Before After
framework/d/actor/d_a_npc daBaseNpc_lookat_c::calc(fopAc_ac_c*, float(*)[4], short) +2678 0.15% 99.75%

@hatal175 hatal175 merged commit 7b550fa into zeldaret:main May 31, 2025
1 check passed
@TakaRikka TakaRikka deleted the npccleanup branch September 1, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants